Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Select #2085

Merged
merged 12 commits into from
Jun 11, 2018
Merged

S3 Select #2085

merged 12 commits into from
Jun 11, 2018

Conversation

chrisradek
Copy link
Contributor

Mostly just a sanity check since all these changes have been separately reviewed.

@codecov-io
Copy link

codecov-io commented Jun 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0a7112b). Click here to learn what that means.
The diff coverage is 95.42%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2085   +/-   ##
========================================
  Coverage          ?     96%           
========================================
  Files             ?     243           
  Lines             ?    7562           
  Branches          ?    1442           
========================================
  Hits              ?    7260           
  Misses            ?     302           
  Partials          ?       0
Impacted Files Coverage Δ
lib/event-stream/split-message.js 100% <100%> (ø)
.../event-stream/event-message-unmarshaller-stream.js 100% <100%> (ø)
lib/event-stream/streaming-create-event-stream.js 100% <100%> (ø)
lib/node_loader.js 88.52% <100%> (ø)
lib/event-stream/to-buffer.js 100% <100%> (ø)
lib/event-stream/buffered-create-event-stream.js 100% <100%> (ø)
lib/event-stream/event-message-chunker.js 100% <100%> (ø)
lib/model/shape.js 95.34% <100%> (ø)
lib/event-stream/int64.js 100% <100%> (ø)
lib/util.js 94.34% <100%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7112b...90853a1. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me!

@chrisradek chrisradek merged commit 9c15bf9 into master Jun 11, 2018
@trivikr trivikr deleted the wip-s3-select branch July 3, 2019 22:09
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants