Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds event stream message parsing #2054

Merged
merged 1 commit into from
May 18, 2018
Merged

Adds event stream message parsing #2054

merged 1 commit into from
May 18, 2018

Conversation

chrisradek
Copy link
Contributor

/cc @AllanFly120
/cc @jeskew

Adds parsing of event stream messages for S3 select.

jeskew
jeskew approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@jeskew jeskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Travis finishes without errors, :shipit:!

@codecov-io
Copy link

codecov-io commented May 17, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (wip-s3-select@e2723e1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             wip-s3-select    #2054   +/-   ##
================================================
  Coverage                 ?   96.01%           
================================================
  Files                    ?      227           
  Lines                    ?     7103           
  Branches                 ?     1372           
================================================
  Hits                     ?     6820           
  Misses                   ?      283           
  Partials                 ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2723e1...35183f1. Read the comment docs.

@chrisradek chrisradek mentioned this pull request May 18, 2018
Closed
AllanZhengYP
AllanZhengYP approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisradek chrisradek merged commit b702e4a into aws:wip-s3-select May 18, 2018
@chrisradek chrisradek deleted the event-message-parser branch May 18, 2018 20:20
chrisradek added a commit to chrisradek/aws-sdk-js that referenced this pull request May 22, 2018
@chrisradek
Adds event stream message parsing (aws#2054)
e024700
chrisradek added a commit to chrisradek/aws-sdk-js that referenced this pull request May 22, 2018
@chrisradek
Adds event stream message parsing (aws#2054)
e213254
chrisradek added a commit that referenced this pull request Jun 11, 2018
@chrisradek
Adds event stream message parsing (#2054)
5c2ed18
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeskew jeskew jeskew approved these changes

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisradek @codecov-io @jeskew @AllanZhengYP