-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UploadDirectoryAsync - delete local file after upload #165
Comments
I'm leery of the SDK being in charge of deleting local files when it seems like a simple thing for the client application to take care of when it knows for sure when to delete the files. Can you give a better reason why you would want that logic in UploadDirectoryAsync? |
The only reason I asked for this is because I can't seem to find a way to detect which files were uploaded and which ones failed. for e.g. when the internet drops after a few files have uploaded. |
At the moment, there is no simple way to detect when the SDK has uploaded a particular item in a directory, but we are thinking of adding a progress callback that would be called when a file has been successfully uploaded to S3. That should allow you to delete the files. |
Thanks that would be great if you can please add this to uploadFileRequest as well. I tried deleting the file at the progress by checking if sent bytes == total bytes but it looks like the file is still open at this stage so i get error file open by other application. |
Glad to hear that this approach will work for your case. |
Feature request to delete file after upload
The text was updated successfully, but these errors were encountered: