Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Support for ModernHttpClient #254

Closed
habermeier opened this issue Oct 9, 2015 · 2 comments
Closed

Suggestion: Support for ModernHttpClient #254

habermeier opened this issue Oct 9, 2015 · 2 comments
Labels
feature-request A feature should be added or improved.

Comments

@habermeier
Copy link

I've not looked at it very deeply, but it would be good if the library could support (optionally) ModernHttpClient: https://github.com/paulcbetts/ModernHttpClient

Given it uses the optimal native implementations for Android and iOS.

@jimfl jimfl added the feature-request A feature should be added or improved. label Oct 9, 2015
@gokarnm
Copy link
Contributor

gokarnm commented Oct 21, 2015

Hi, I've added this feature request to our backlog and will update you when we implement it. In the meanwhile, if you want to try ModernHttpClient, you can easily modify the code to use ModernHttpClient. ModernHttpClient is implemented as a custom HttpClient handler, so you can use it instead of the default HttpClientHandler here - https://github.com/aws/aws-sdk-net/blob/master/sdk/src/Core/Amazon.Runtime/Pipeline/HttpHandler/_mobile/HttpRequestMessageFactory.cs#L340 .

var httpClient = new HttpClient(new NativeMessageHandler());

You can additionally set configuration options which ModernHttpClient supports similar to this code - https://github.com/aws/aws-sdk-net/blob/master/sdk/src/Core/Amazon.Runtime/Pipeline/HttpHandler/_mobile/HttpRequestMessageFactory.cs#L333-L338

@jimfl
Copy link
Contributor

jimfl commented Oct 23, 2015

@jimfl jimfl closed this as completed Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants