Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone AWS4Signer package for IAM Authorization #2619

Closed
2 tasks
tking2096 opened this issue May 31, 2023 · 6 comments
Closed
2 tasks

Standalone AWS4Signer package for IAM Authorization #2619

tking2096 opened this issue May 31, 2023 · 6 comments
Labels
credentials duplicate This issue is a duplicate. feature-request A feature should be added or improved.

Comments

@tking2096
Copy link

Describe the feature

For .NET developers attempting to build IAM Authorized API clients, extract the AWS4Signer's functionality into it's own NuGet package. Make it able to sign regular System.Net.Http requests.

Use Case

As API Gateway's popularity increases, more and more developers will need an implementation of AWS Signature Version 4. Rest Api's have the handy SDK generation to take care of this for Java, JavaScript, Java for Android, Objective-C or Swift for iOS, and Ruby, but .NET is left out. AWS4Signer.cs is fairly specialized for signing AWS service requests from the AWSSDK, so developers that are attempting to integrate to their own API Gateway api's may have a hard time adapting it to fit their own needs.

There are some open source NuGet packages for this, but many organizations would much prefer an AWS-maintained implementation.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWSSDK.Core 3.7.106.44

Targeted .NET Platform

.NET 6, .NET Standard 2.0

Operating System and version

Windows, Linux, Mac OS, anywhere .NET is used

@tking2096 tking2096 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 31, 2023
@ashishdhingra
Copy link
Contributor

ashishdhingra commented May 31, 2023

@tking2096 Good afternoon. Please review if your request is similar to existing feature request #1905 and if we could close this one.

Thanks,
Ashish

@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels May 31, 2023
@tking2096
Copy link
Author

@ashishdhingra My request is for a more broad scope than Cognito. It is for any consumer of an API that uses an IAM Authorizer. For example, an EC2 accesses an API Gateway HTTP API using its Instance Profile.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 1, 2023
@ashishdhingra
Copy link
Contributor

@ashishdhingra My request is for a more broad scope than Cognito. It is for any consumer of an API that uses an IAM Authorizer. For example, an EC2 accesses an API Gateway HTTP API using its Instance Profile.

@tking2096 My apologies, there was copy/paste error. I'm referring to existing feature request #1905. Please review.

Thanks,
Ashish

@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-review labels Jun 1, 2023
@tking2096
Copy link
Author

@ashishdhingra I do see the similarities. Although, #1905 is only referring to Query Parameter authentication. If you think they ought to be consolidated, fair enough. I think my description of the feature adds helpful details.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 3, 2023
@ashishdhingra ashishdhingra added the duplicate This issue is a duplicate. label Jun 6, 2023
@ashishdhingra
Copy link
Contributor

@ashishdhingra I do see the similarities. Although, #1905 is only referring to Query Parameter authentication. If you think they ought to be consolidated, fair enough. I think my description of the feature adds helpful details.

@tking2096 Thanks. I have added a note in the other feature request. Closing this as duplicate.

@ashishdhingra ashishdhingra closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
credentials duplicate This issue is a duplicate. feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants