Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for guzzlehttp/promises:^2.0 #2713

Closed
2 tasks
amangrover90 opened this issue Jun 16, 2023 · 5 comments
Closed
2 tasks

Missing support for guzzlehttp/promises:^2.0 #2713

amangrover90 opened this issue Jun 16, 2023 · 5 comments
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@amangrover90
Copy link

Describe the feature

The package guzzlehttp/promises v2.0.0 was released on the 2023-05-21. Could you consider adding support for this version?

This package being incompatible with guzzlehttp/promises:^2.0 makes it incompatible with Drupal 10.1-rc1.

Screenshot 2023-06-16 at 11 38 57 AM

Use Case

Compatibility with guzzlehttp/promises.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.273.1

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP8.1 - Macos as well as PHP8.1 on Linux.

@amangrover90 amangrover90 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 16, 2023
@stobrien89
Copy link
Member

Hi @amangrover90,

Thanks for reaching out and sorry to hear about the issues. We're unable to add support for guzzlehttp/promises v2.0.0 for backward-compatibility reasons— because we support down to PHP 5.5 at this time, we're unable to allow libraries that have type declarations. This will be changing on August 15th. Keep an eye on #2707 for updates.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@IanSimpson
Copy link

@stobrien89 Can't you still require ^1.0 || ^2.0? This is what Guzzle itself does, and you support the latest version of Guzzle (which itself only supports PHP 7) fine.

@stobrien89
Copy link
Member

Hi @IanSimpson,

Sorry, should have elaborated— We have classes which either implement psr7 interfaces. They won't be compatible with V2 until we move forward with the deprecation.

@jabeler
Copy link

jabeler commented Jun 22, 2023

In the short term, it looks like Drupal will be addressing this issue on their end to remove the block which prevents 10.1 from being installed.

https://www.drupal.org/project/drupal/issues/3368790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

4 participants