Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry S3 transfers on BadDigest error #1264

Closed
corasaurus-hex opened this issue Aug 2, 2016 · 6 comments
Closed

Retry S3 transfers on BadDigest error #1264

corasaurus-hex opened this issue Aug 2, 2016 · 6 comments
Labels
feature-request A feature should be added or improved.

Comments

@corasaurus-hex
Copy link

I have run into issues with BadDigest errors while running upload_file and put_object where somehow, inexplicably, the MD5 of the content is incorrect. It would be nice if the SDK retried uploads with a BadDigest and while retrying recalculated the digest.

Thanks!
@awood45 awood45 added Version 2 feature-request A feature should be added or improved. labels Aug 3, 2016
@awood45
Copy link
Member

awood45 commented Aug 3, 2016

It sounds like you've had a discussion with Trevor about this, we'll take the retry on as a feature request.

@corasaurus-hex
Copy link
Author

Yup, thanks!

@awood45
Copy link
Member

awood45 commented Sep 9, 2016

Added to feature request backlog.

@awood45 awood45 closed this as completed Sep 9, 2016
@mullermp
Copy link
Contributor

Reopening - deprecating usage of Feature Requests backlog markdown file.

@mullermp mullermp reopened this Oct 21, 2019
@mullermp mullermp removed the v2 label Oct 21, 2019
@mullermp
Copy link
Contributor

mullermp commented Jul 8, 2020 •
edited
Loading

I haven't heard any reports of this still happening. By chance were you using a tempfile and not rewinding it? At the worst case, this error can be added to the list here. I am going to close this for now.

@mullermp mullermp closed this as completed Jul 8, 2020
@mullermp
Copy link
Contributor

mullermp commented Jul 8, 2020

As of recently, checksums are handled here: https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/lib/aws-sdk-core/plugins/http_checksum.rb

@lukaszfiszer-monday lukaszfiszer-monday mentioned this issue Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@corasaurus-hex @awood45 @mullermp