Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Shield - listProtections Pagination not supported #14

Closed
kishorchintal opened this issue Oct 24, 2018 · 4 comments
Closed

Shield - listProtections Pagination not supported #14

kishorchintal opened this issue Oct 24, 2018 · 4 comments
Assignees
Labels
feature-request New feature or request shield

Comments

@kishorchintal
Copy link

listProtections API does not support pagination. On researching the issue, it was found that pagination configuration is empty in here - https://github.com/aws/aws-sdk-js/blob/master/apis/shield-2016-06-02.paginators.json.

We could retrieve all the records only after updating the paginators json with below

{ "pagination":{ "ListProtections":{ "input_token":"NextToken", "limit_key":"MaxResults", "output_token":"NextToken", "result_key":"Protections" } } }

@srchase
Copy link

srchase commented Oct 24, 2018

Hello @kishorchintal,

Thanks for reporting this issue.

I've marked this as a Feature Request. You're correct that the underlying listProtections API supports pagination, but that the SDK currently does not. We'll need to review and work with the Shield Service team to make this available in the SDK.

@ajredniwja ajredniwja transferred this issue from aws/aws-sdk-js Nov 6, 2020
@ajredniwja ajredniwja added feature-request New feature or request service-api This issue pertains to the AWS API labels Nov 7, 2020
@stobrien89 stobrien89 added shield and removed service-api This issue pertains to the AWS API labels Jul 26, 2021
@AllanZhengYP
Copy link
Contributor

AllanZhengYP commented Oct 26, 2021

The Paginator is now supported. Thank you for bringing this up! This ticket can be closed now.

@RanVaknin RanVaknin assigned RanVaknin and unassigned trivikr Sep 27, 2023
@RanVaknin
Copy link

Closing.

@github-actions
Copy link

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or request shield
Projects
None yet
Development

No branches or pull requests

7 participants