Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

ValidationException is not in errors.go #47

Closed
itsdax opened this issue Feb 17, 2020 · 8 comments
Closed

ValidationException is not in errors.go #47

itsdax opened this issue Feb 17, 2020 · 8 comments
Assignees
Labels
dynamodb feature-request New feature or request service-api This issue pertains to the AWS API

Comments

@itsdax
Copy link

itsdax commented Feb 17, 2020

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

v1.29.3

Version of Go (go version)?

1.13

What issue did you see?

ValidationException is not in errors.go, but it is an exception that is returned

Steps to reproduce

	output, err := a.db.Query(queryInput)
	if err != nil {
		if e, ok := err.(awserr.Error); ok {
			switch e.Code() {
			case "ValidationException": // I have to use a custom string for this case
				return nil, "", &InvalidQueryError{err, "bad input"}
			case dynamodb.ErrCodeConditionalCheckFailedException:
				return nil, "", &InvalidQueryError{err, "failed things"}
@diehlaws diehlaws self-assigned this Feb 19, 2020
@diehlaws
Copy link

Hi @itsdax, thanks for bringing this to our attention. Looking at the API model for DynamoDB it appears that ValidationException is not being modeled for this service. As a result it makes sense that this exception is not present in service/dynamodb/errors.go since the code surrounding a service's client and its associated methods & structures in each AWS SDK is generated based on the API model provided to us by the service team.

That being said, I'll be reaching out to the DynamoDB team internally regarding this exception not being modeled since it seems like it should be. Once I have more information on this I'll update the issue accordingly.

@itsdax
Copy link
Author

itsdax commented Mar 11, 2020

any updates?

@diehlaws
Copy link

Unfortunately the DynamoDB team has not yet responded to this request. I've reached out to them again asking for attention on the issue.

@diehlaws diehlaws removed their assignment Aug 26, 2020
@nikoremi97
Copy link

Same for Kinesis, I think there should be many more with the same issue.

@skmcgrail skmcgrail transferred this issue from aws/aws-sdk-go Mar 26, 2021
@future-ito-masahiko
Copy link

I encountered the same problem, and found this issue.
I hope "ValidationException" will be treated as const in somewhere.

@ajredniwja ajredniwja added feature-request New feature or request service-api This issue pertains to the AWS API labels May 3, 2021
@stobrien89 stobrien89 added dynamodb and removed service-api This issue pertains to the AWS API labels Jul 26, 2021
@stobrien89
Copy link
Member

Created another ticket to track this: P51608118

@tim-finnigan tim-finnigan self-assigned this Jun 9, 2022
@tim-finnigan tim-finnigan added the service-api This issue pertains to the AWS API label Jun 9, 2022
@tim-finnigan
Copy link
Contributor

We were informed that the DynamoDB team added this request to their backlog for further review. We recommend reaching out through AWS Support for updates going forward, but feel free to check back in here as well.

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dynamodb feature-request New feature or request service-api This issue pertains to the AWS API
Projects
None yet
Development

No branches or pull requests

7 participants