-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(featureDev): Prevent crash on large repos or unsupported encoding during file collection #4888
Conversation
7a8d0ab
to
3eb3438
Compare
3eb3438
to
858e55a
Compare
Just one more thing, are you able to add a changelog? I'm sure theres some users that would like to know this is fixed 😄 |
858e55a
to
0d1ceea
Compare
Yes, definitely! Just added a changelog with the bugfix :) |
@@ -137,9 +153,9 @@ export async function prepareRepoData( | |||
span: Metric<AmazonqCreateUpload> | |||
) { | |||
try { | |||
const files = await collectFiles(repoRootPaths, workspaceFolders, true) | |||
const zip = new AdmZip() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current approach used to zip files does not "stream" the zip creation so will also run into memory constraints.
please look at #4769 , can you rewrite this feature on top of that (after it lands)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the ETA of this being ready? Presume we want both these in the same wave of the toolkit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm happy to change our implementation to use the stream after it's merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the ETA of this being ready?
The zip streaming won't be ready today, but hopefully next week. @ctlai95
0d1ceea
to
37b71b0
Compare
… during file collection
37b71b0
to
21428f5
Compare
Problem
There are currently 2 problems in featureDev when doing collection of repository files:
Solution
This CR fixes both problems by:
Users who try to use featureDev on a codebase larger than 200mb will see a message asking for a different workspace to be selected.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.