Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codewhisperer: send customizationArn via telemetry clientComponentLatency, perceivedLatency #5035

Merged
merged 6 commits into from
May 23, 2024

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented May 21, 2024

Telemetry Common repo PR: aws/aws-toolkit-common#738

Problem

Solution

Add customizationArn field when sending clientComponentLatency, perceivedLatency

BuilderId

vsc_perceivedLatency_builderId

vsc_componentLatency_builderId

IdC - default foundation

vsc_perceivedLatency_idc_foundation

vsc_componentLatency_idc_foundation

IdC - using customization

vsc_clientComponentLatency

vsc_perceivedLatency

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested review from a team as code owners May 21, 2024 19:12
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented May 21, 2024

will revert telemetry override after telemetry version bump [DONE]

@Will-ShaoHua
Copy link
Contributor Author

irrelevant to this PR(testing with market place Q plugin and was able to repro), notice there is a log entry which we might need to fix

2024-05-21 13:13:23.506 [warning] telemetry: invalid Metric: "codewhisperer_clientComponentLatency" emitted without the `result` property, which is always required. Consider using `.run()` instead of `.emit()`, which will set these properties automatically. See https://github.com/aws/aws-toolkit-vscode/blob/master/docs/

@hayemaxi
Copy link
Contributor

will revert telemetry override after telemetry version bump

Can't we remove it in this PR since the version is being bumped here?

@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented May 22, 2024

Can't we remove it in this PR since the version is being bumped here?

@hayemaxi yea it's been removed , a883008

@justinmk3 justinmk3 merged commit 62d98ae into aws:master May 23, 2024
14 checks passed
@Will-ShaoHua Will-ShaoHua deleted the telemetry branch May 24, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants