chore(auth): add login tests #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
May 28, 2024
| }) | ||
| }) | ||
|
|
||
| it('successfully signs into account IdC and emits telemetry', async function () { |
There was a problem hiding this comment.
"successfully" is usually redundant in test names. It would be unusual to test that something failed (and then we would say "fails" in the name)
Suggested change
| it('successfully signs into account IdC and emits telemetry', async function () { | |
| it('signs into account IdC and emits telemetry', async function () { |
justinmk3
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some basic tests. We could use some more tests that cover the connection re-use functionality.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.