Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate project name #5

Closed
efekarakus opened this issue Aug 21, 2019 · 4 comments
Closed

Validate project name #5

efekarakus opened this issue Aug 21, 2019 · 4 comments
Assignees

Comments

@efekarakus
Copy link
Contributor

efekarakus commented Aug 21, 2019

Story

As a user that entered the project name to the ecs init prompt or flag,
I want the CLI to give me an error before it proceeds creating my resources,
So that I don't do additional wasted work before getting an error message.

Acceptance Criteria

  • Has to be less than 255 characters

This is because a project's name will be used as a tag value which has to be < 255 chars. Note: I'm not sure what this means for unicode characters we might want to test this out.

  • Must be alphanumeric (A-Za-z0-9)

We will use a combination of project name and application name to create the Logical ID of CFN resources. CFN has a restriction of alphanumeric ids.

  • Must be unique within the account.

Check if the tool account already has a tag value set to project.

@efekarakus
Copy link
Contributor Author

@kohidave Am I missing anything else for validation?

@sonofachamp
Copy link
Contributor

  • Must be unique within the account.
    Check if the tool account already has a tag value set to project.

I don't understand what tool account means.

  • Is checking for uniqueness within an account a web service call?
  • Would the check be against all resources or only a specific set of resources?

@kohidave
Copy link
Contributor

tool account refers to the account that's hosting the project configuration and CodePipes. It's defined in the Cross Account CodePipeline Reference Architecture.

Checking uniqueness would involve calling SSM (depending on our project configuration choice).

@efekarakus - those are good first starts. I can't think of anything else off the top of my head.

@sonofachamp
Copy link
Contributor

I've opened #19 to include basic validations and will open a separate issue to track uniqueness within a tool account scope work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants