Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add cfn snippets for bare-boned pre/post deployment actions #5109

Merged
merged 15 commits into from
Aug 4, 2023
Merged

chore: add cfn snippets for bare-boned pre/post deployment actions #5109

merged 15 commits into from
Aug 4, 2023

Conversation

Lou1415926
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Lou1415926 Lou1415926 requested a review from a team as a code owner July 20, 2023 19:05
@Lou1415926 Lou1415926 requested review from iamhopaul123 and removed request for a team July 20, 2023 19:05
@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51492 51400 +0.18
macOS (arm) 51700 51604 +0.19
linux (amd) 45328 45244 +0.19
linux (arm) 43588 43524 +0.15
windows (amd) 42148 42072 +0.18

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023 •
edited

Codecov Report

Merging #5109 (3e31c13) into mainline (41a7640) will decrease coverage by 0.15%.
Report is 20 commits behind head on mainline.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           mainline    #5109      +/-   ##
============================================
- Coverage     69.65%   69.51%   -0.15%     
============================================
  Files           295      295              
  Lines         43071    43333     +262     
  Branches        285      285              
============================================
+ Hits          30003    30124     +121     
- Misses        11602    11740     +138     
- Partials       1466     1469       +3
Files Changed Coverage Δ
internal/pkg/deploy/pipeline.go 62.84% <0.00%> (-1.05%) ⬇️
internal/pkg/template/pipeline.go 58.62% <ø> (ø)

... and 21 files with indirect coverage changes

@dannyrandall dannyrandall added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 2, 2023
@huanjani huanjani removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 2, 2023
huanjani
huanjani approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lou1415926 @huanjani
Update internal/pkg/deploy/pipeline.go
3e31c13 
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
@mergify mergify bot merged commit 7dd974f into aws:mainline Aug 4, 2023
12 checks passed
Sprint 🏃‍♀️ automation moved this from In review to Pending release Aug 4, 2023
@huanjani huanjani mentioned this pull request Aug 21, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 24, 2023
@huanjani
feat(pipelines): add pre- and post- deployment fields to pipeline man…
9e31326 
…ifests (#5209)

Related: #5109, #3007.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamhopaul123 iamhopaul123 iamhopaul123 left review comments

@huanjani huanjani huanjani approved these changes

@KollaAdithya KollaAdithya KollaAdithya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sprint 🏃‍♀️
  
Pending release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Lou1415926 @codecov-commenter @iamhopaul123 @huanjani @KollaAdithya @dannyrandall