feat(pipelines): add pre- and post- deployment fields to pipeline manifests#5209
Merged
mergify[bot] merged 21 commits intoaws:mainlinefrom Aug 24, 2023
Merged
feat(pipelines): add pre- and post- deployment fields to pipeline manifests#5209mergify[bot] merged 21 commits intoaws:mainlinefrom
mergify[bot] merged 21 commits intoaws:mainlinefrom
Conversation
huanjani
requested review from
CaptainCarpensir
and removed request for
a team
|
🍕 Here are the new binary sizes!
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mainline #5209 +/- ##
============================================
+ Coverage 69.79% 69.84% +0.05%
============================================
Files 296 296
Lines 44146 44300 +154
Branches 286 286
============================================
+ Hits 30812 30943 +131
- Misses 11843 11861 +18
- Partials 1491 1496 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
Can we add an integration test for adding these pre/post deployment fields to the manifest?
Lou1415926
reviewed
Aug 22, 2023
Lou1415926
reviewed
Aug 23, 2023
Contributor
Author
discussed offline. will leave the current one as is; in the future we should add integ tests that are similar to "DD" but truly go from manifest to cfn template. |
Lou1415926
reviewed
Aug 23, 2023
Lou1415926
approved these changes
Aug 24, 2023
| - !Join [ '', [ 'arn:aws:s3:::', 'fancy-bucket', '/*' ] ] | ||
| - Effect: Allow | ||
| Action: | ||
| # TODO: scope this down if possible |
Contributor
There was a problem hiding this comment.
should we leave these TODO's in here...?
| Type: AWS::IAM::Role | ||
| Properties: | ||
| Path: / | ||
| AssumeRolePolicyDocument: |
Contributor
There was a problem hiding this comment.
is this policy doc the same as the one above? i wonder if it's better to use AWS::IAM::POLICY and just list all of the roles ARNs in Roles 🤔
iamhopaul123
added
the
do-not-merge
iamhopaul123
approved these changes
Aug 24, 2023
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
feel free to remove the label
huanjani
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #5109, #3007.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.