-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable importing public-facing ALBs #5438
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5438 +/- ##
============================================
+ Coverage 69.91% 69.94% +0.02%
============================================
Files 299 301 +2
Lines 45497 45901 +404
Branches 295 295
============================================
+ Hits 31810 32105 +295
- Misses 12141 12232 +91
- Partials 1546 1564 +18
☔ View full report in Codecov by Sentry. |
🍕 Here are the new binary sizes!
|
internal/pkg/template/templates/workloads/partials/cf/envvars-common.yml
Show resolved
Hide resolved
internal/pkg/template/templates/workloads/partials/cf/imported-alb-resources.yml
Outdated
Show resolved
Hide resolved
internal/pkg/template/templates/workloads/partials/cf/imported-alb-resources.yml
Outdated
Show resolved
Hide resolved
Type: AWS::ElasticLoadBalancingV2::ListenerRule | ||
Properties: | ||
Actions: | ||
- Type: redirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe not in this release, but we might want to consider the http.redirect_to_https
manifest field like in
copilot-cli/internal/pkg/template/templates/workloads/partials/cf/https-listener.yml
Line 85 in baf2a78
{{- if $rule.RedirectToHTTPS}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR mostly looks good to me. Awesome! My main concern is regarding the new imported-alb-resources
file (+1 to wx's fb and see comments below)
internal/pkg/template/templates/workloads/partials/cf/imported-alb-resources.yml
Outdated
Show resolved
Hide resolved
internal/pkg/template/templates/workloads/partials/cf/imported-alb-resources.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
… into imported-albs
internal/pkg/template/templates/environment/partials/custom-resources.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to remove the label whenever you are ready!
Related: #5438. Integ test changes in #5483. #5483 adds the Load Balancer DNS name to the service as an env var (and therefore appears in `svc show` output. However, it is not (yet) included in URI output as a recommended action in `svc deploy` output. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Import an existing ALB that is within the deployment environment's VPC by adding
to a Load-Balanced Web Service's manifest.
Related: #3319, #1457, #3936.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.