Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add LB_DNS env var for internal ALBs #5483

Merged
merged 8 commits into from
Dec 1, 2023
Merged

chore: add LB_DNS env var for internal ALBs #5483

merged 8 commits into from
Dec 1, 2023

Conversation

huanjani
Copy link
Contributor 

Variables

  Name                                Container  Environment           Value
  ----                                ---------  -----------           -----
  COPILOT_APPLICATION_NAME            be         env-name-with-dashes  v129-testing
    "                                   "        test                    "
  COPILOT_ENVIRONMENT_NAME              "        env-name-with-dashes  env-name-with-dashes
    "                                   "        test                  test
  COPILOT_LB_DNS                        "        env-name-with-dashes  internal-internalALBforImport-1595089742.us-west-2.elb.amazonaws.com
  COPILOT_SERVICE_DISCOVERY_ENDPOINT    "          "                   env-name-with-dashes.v129-testing.local
    "                                   "        test                  test.v129-testing.local
  COPILOT_SERVICE_NAME                  "        env-name-with-dashes  be
    "                                   "        test                    "

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@huanjani huanjani requested a review from a team as a code owner November 15, 2023 19:36
@huanjani huanjani requested review from CaptainCarpensir and removed request for a team November 15, 2023 19:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56640 55192 🥺 +2.62
macOS (arm) 57644 56144 🥺 +2.67
linux (amd) 49660 48440 🥺 +2.52
linux (arm) 48896 47748 🥺 +2.40
windows (amd) 46792 45672 🥺 +2.45

@huanjani huanjani marked this pull request as draft November 15, 2023 19:55
@huanjani huanjani marked this pull request as ready for review November 15, 2023 20:38
@huanjani huanjani mentioned this pull request Nov 16, 2023
Merged
@mergify mergify bot merged commit 9103b4d into aws:mainline Dec 1, 2023
12 checks passed
mergify bot pushed a commit that referenced this pull request Jun 3, 2024
@huanjani
feat: support importing internal ALBs for backend services (#5490)
28e656c 
Related: #5438. 
Integ test changes in #5483.

#5483 adds the Load Balancer DNS name to the service as an env var (and therefore appears in `svc show` output. However, it is not (yet) included in URI output as a recommended action in `svc deploy` output. 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamhopaul123 iamhopaul123 iamhopaul123 approved these changes

@CaptainCarpensir CaptainCarpensir CaptainCarpensir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huanjani @iamhopaul123 @CaptainCarpensir