Node: Fix issues with type import & exports #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikolomi
approved these changes
Jan 16, 2024
This saves us declaring each type that should be exported. This is done because multiple types haven't been exported, and so would've been harder for our users to use.
This is done so that we won't expose Protobuf types externally, since Protobuf doesn't create good Typescript bindings.
It's exported for testing, not for the user.
Importing types from files and not the index helped hide the fact that these types weren't exported.
This will remove non user-facing types from the release.
shachlanAmazon
force-pushed
the
node-types
branch
from
4dd50fc
to
5afcbe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Some types that should be user-facing weren't exported in the index.ts file.
Some types that shouldn't be user-facing were exported, for use in tests.
Protobuf types, which don't have good Typescript definitions, were exported to the user.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.