Added zcount command in node. #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adanWattad
force-pushed
the
node/zcount
branch
2 times, most recently
from
5393d0a
to
59a02b9
Compare
|
Please talk with @shohamazon, we saw that we need to refactor this command implementation in python |
|
please align tests with #911 |
barshaul
reviewed
Feb 13, 2024
| maxScore: ScoreLimit | ||
| ): redis_request.Command { | ||
| const args = [key]; | ||
|
|
There was a problem hiding this comment.
lets have consts for the args values, e.g.:
const positiveInfinityArg = "+inf"
const negativeInfinityArg = "-inf"
const isInclusiveArg = "("
barshaul
reviewed
Feb 13, 2024
| ).toEqual(0); | ||
| }); | ||
| }, | ||
| config.timeout |
There was a problem hiding this comment.
please add a test for if key holds a value that is not a sorted set
barshaul
approved these changes
Feb 13, 2024
adanWattad
force-pushed
the
node/zcount
branch
from
59a02b9
to
a51f63c
Compare
adanWattad
force-pushed
the
node/zcount
branch
from
a51f63c
to
c60a567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.