Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: adds ECHO command #953

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

shohamazon
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon requested a review from a team as a code owner February 13, 2024 16:05
@shohamazon shohamazon force-pushed the python/echo branch 2 times, most recently from a1802f3 to 98d58fc Compare February 13, 2024 16:13
@@ -1121,6 +1121,24 @@ async def ttl(self, key: str) -> int:
"""
return cast(int, await self._execute_command(RequestType.TTL, [key]))

async def echo(self, message: str) -> str:
"""
Returns `message`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoes the provided message back.

message (str): The message to be echoed back.

Returns:
str: The `message` sent as an argument.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided message

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix also in transaction & merge

@shohamazon shohamazon merged commit 5e41f52 into valkey-io:main Feb 18, 2024
29 checks passed
@shohamazon shohamazon deleted the python/echo branch February 18, 2024 16:42
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants