Skip to content

Commit

Permalink
fix(jsii): unable to depend on modules with private declarations (#995)
Browse files Browse the repository at this point in the history
Due to a TypeScript [bug], it was impossible to write a jsii module
that takes a dependency on a module that has private type declarations
in their d.ts file since they are untyped by definition.

This temporary fix sets `noImplicitAny` to `false` in order to disable
this check and enable the dependency use case until we upgrade to the 3.7.x
version-line.

Fixes #994

[bug]: microsoft/TypeScript#33894
  • Loading branch information
Elad Ben-Israel authored and mergify[bot] committed Nov 17, 2019
1 parent c852f16 commit 08c4294
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/jsii/lib/compiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const COMPILER_OPTIONS: ts.CompilerOptions = {
module: ts.ModuleKind.CommonJS,
noEmitOnError: true,
noFallthroughCasesInSwitch: true,
noImplicitAny: true,
noImplicitAny: false, // temporarily "false" until we upgrade typescript in order to solve #994
noImplicitReturns: true,
noImplicitThis: true,
noUnusedLocals: true,
Expand Down

0 comments on commit 08c4294

Please sign in to comment.