Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsserverlibrary.d.ts contains implicitAny error #33894

Closed
ajafff opened this issue Oct 9, 2019 · 3 comments · Fixed by #33896
Closed

tsserverlibrary.d.ts contains implicitAny error #33894

ajafff opened this issue Oct 9, 2019 · 3 comments · Fixed by #33896
Labels
Bug A bug in TypeScript
Milestone
TypeScript 3.6.5

Comments

@ajafff
Copy link
Contributor

ajafff commented Oct 9, 2019

TypeScript Version: v3.7.0-dev.20191009

Search Terms:

Code

tsc --noEmit --strict node_modules/typescript/lib/tsserverlibrary.d.ts

Expected behavior:

No error

Actual behavior:

node_modules/typescript/lib/tsserverlibrary.d.ts:8559:21 - error TS7033: Property 'typingsCache' implicitly has type 'any', because its get accessor lacks a return type annotation.

8559         private get typingsCache();
                         ~~~~~~~~~~~~


Found 1 error.
@ajafff
Copy link
Contributor Author

ajafff commented Oct 9, 2019

On second thought this is probably not a problem with tsserverlibrary.d.ts. It seems the check for implicitAny getters should exclude private ones.

@ajafff ajafff mentioned this issue Oct 9, 2019
Merged
@nmain
Copy link

nmain commented Oct 9, 2019

Related to #33877

@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Oct 9, 2019
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.7.1 milestone Oct 9, 2019
@RyanCavanaugh
Copy link
Member

Nice catch @ajafff

@eladb eladb mentioned this issue Nov 17, 2019
Closed
1 task
eladb pushed a commit to aws/jsii that referenced this issue Nov 17, 2019
fix(jsii): unable to depend on modules with private declarations
2e9852c 
Due to a TypeScript [bug], it was impossible to write a jsii module
that takes a dependency on a module that has private type declarations
in their d.ts file since they are untyped by definition.

This temporary fix sets `noImplicitAny` to `false` in order to disable
this check and enable the dependency use case until we upgrade to the 3.7.x
version-line.

Fixes #994

[bug]: microsoft/TypeScript#33894
@eladb eladb mentioned this issue Nov 17, 2019
Merged
mergify bot pushed a commit to aws/jsii that referenced this issue Nov 17, 2019
@mergify
fix(jsii): unable to depend on modules with private declarations (#995)
08c4294 
Due to a TypeScript [bug], it was impossible to write a jsii module
that takes a dependency on a module that has private type declarations
in their d.ts file since they are untyped by definition.

This temporary fix sets `noImplicitAny` to `false` in order to disable
this check and enable the dependency use case until we upgrade to the 3.7.x
version-line.

Fixes #994

[bug]: microsoft/TypeScript#33894
@NGL321 NGL321 mentioned this issue Dec 20, 2019
Closed
@ssong ssong mentioned this issue Jan 8, 2020
Closed
@pkanher617 pkanher617 mentioned this issue Sep 8, 2020
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript
Projects
None yet
Milestone
TypeScript 3.6.5
Development

Successfully merging a pull request may close this issue.

Fix noImplicitAny check on ambient private getters ajafff/TypeScript
4 participants
@DanielRosenwasser @RyanCavanaugh @ajafff @nmain