Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): runtime release tagging #2417

Merged
merged 16 commits into from
Jan 14, 2021
Merged

Conversation

MrArnoldPalmer
Copy link
Contributor

Adds github actions workflows for automatically tagging jsii-runtime-go
when jsii release branch is updated. This essentially publishes new
runtime version. This may eventually be served better in delivlib but is
much simpler in github actions for the alpha phase.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrArnoldPalmer MrArnoldPalmer requested review from RomainMuller and a team January 13, 2021 04:37
@MrArnoldPalmer MrArnoldPalmer changed the title Feature/go runtime release tagging feat(go): runtime release tagging Jan 13, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 13, 2021
.github/workflows/main.yml Show resolved Hide resolved
Comment on lines 497 to 500
- uses: actions/cache@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cache is... okay, but it's not doing as much work as it could... You'd probably benefit from also caching Yarn's cache, like the other jobs do.

Also - not sure how this deals with symlinks... I'd be tempted to be somewhat afraid it caches the referents of the symlinks to packages within the monorepo... Could this have consequences?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemme know if this is more what you were thinking. Since this only needs yarn deps tried to exclude all the other languages package caches.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
  • Commit ID: a0d524f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jan 14, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2021

Merging (with squash)...

@RomainMuller RomainMuller merged commit 9ffd204 into main Jan 14, 2021
@RomainMuller RomainMuller deleted the feature/go-runtime-release-tagging branch January 14, 2021 17:57
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants