Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET - Correctly deserialize callback arguments #404

Closed
RomainMuller opened this issue Mar 27, 2019 · 1 comment
Closed

.NET - Correctly deserialize callback arguments #404

RomainMuller opened this issue Mar 27, 2019 · 1 comment
Labels
closed-for-staleness language/dotnet Related to .NET bindings (C#, F#, ...) needs-discussion This issue/PR requires more discussion with community. p0

Comments

@RomainMuller
Copy link
Contributor

In #395, a shallow fix was introduced to solve an issue where the Callback arguments were not parsed out to a native object, and instead resolved to JObjects.

As we are moving forward to pass "value types" (also known as "data types") as plain JSON objects (and not by reference), this problem might become more prevalent and require more complex handling (including support for parsing out Date and Enum Constants).

The compliance test in #395 exercises some of this behavior (might benefit from being enriched to include Date and Enum assertions, too).

@RomainMuller RomainMuller added the language/dotnet Related to .NET bindings (C#, F#, ...) label Mar 27, 2019
@fulghum fulghum added the p0 label Apr 2, 2019
@fulghum fulghum added the needs-discussion This issue/PR requires more discussion with community. label Apr 22, 2019
@RomainMuller RomainMuller added this to the .NET Support milestone Jul 30, 2019
@RomainMuller RomainMuller removed this from the .NET Support milestone Jul 21, 2020
@MrArnoldPalmer MrArnoldPalmer removed their assignment Jun 28, 2021
@github-actions
Copy link
Contributor

This issue has not received any attention in 2 years. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 29, 2023
@github-actions github-actions bot closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness language/dotnet Related to .NET bindings (C#, F#, ...) needs-discussion This issue/PR requires more discussion with community. p0
Projects
None yet
Development

No branches or pull requests

4 participants