Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsii-docgen does not use jsii-rosetta@5 #4175

Closed
ahammond opened this issue Jul 10, 2023 · 2 comments
Closed

jsii-docgen does not use jsii-rosetta@5 #4175

ahammond opened this issue Jul 10, 2023 · 2 comments
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@ahammond
Copy link

Describe the bug

All my CI pipelines have the following warning in them:

#######################################################################################################
### You are currently using jsii-rosetta@1.x. We recommend upgrading to jsii-rosetta@5.0.x or       ###
### later. This will allow you to use modern TypeScript syntax, and improves compatibility with     ###
### many common dependencies. For example, recent versions of @types/node.                          ###
###                                                                                                 ###
### 5.0.x and subsequent releases of jsii-rosetta use the same major.minor version as the           ###
### TypeScript compiler they are built on. We recommend declaring a minor-pinned (also known as     ###
### "tilde") dependency on jsii-rosetta (e.g: `"jsii-rosetta": "5.0.x"` or                          ###
### `"jsii-rosetta": "~5.0.7"`).                                                                    ###
###                                                                                                 ###
### For more information, see: https://aws.github.io/jsii/compiler-and-rosetta-maintenance/         ###
###                                                                                                 ###
### This warning can be suppressed by setting the JSII_SUPPRESS_UPGRADE_PROMPT environment variable ###
#######################################################################################################

I have upgraded the repo to use jsii-rosetta: "5.0.x". However, when I look at a yarn.lock, I see

jsii-pacmak@^1.84.0:
  version "1.84.0"
  resolved "https://registry.yarnpkg.com/jsii-pacmak/-/jsii-pacmak-1.84.0.tgz#6501f9968dcd3fe023892cf07da82032e99f8901"
  integrity sha512-+EGfpQDPSyDNPWclcOes6dUhwDsn5dG0bBgVb3hpRWZ0uDe7wLCVwGxh7fphx2XtNvTwdNfspTSBLBMqscOYmg==
  dependencies:
    ...
    jsii-rosetta "^1.84.0"
    ...

Which appears to be dragging the deprecated old version in, too.

Expected Behavior

I expected jsii-docgen to use modern jsii-rosetta, rather than filling my CI logs.

Current Behavior

At the very least I have warnings. I don't know if that means we also have issues. It appears to be localized to docgen.

Reproduction Steps

Use projen to create an aws-cdk Construct Library project.
https://projen.io/api/API.html#projen-awscdk-awscdkconstructlibrary
Publish it into a GH repo.
Watch the CI scream about docgen.

Possible Solution

Update deps...

Additional Information/Context

No response

SDK version used

irrelevant

Environment details (OS name and version, etc.)

irrelevant

@ahammond ahammond added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 10, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Aug 24, 2023

Definitely fixed now.
cdklabs/jsii-docgen#1067

@mrgrain mrgrain closed this as completed Aug 24, 2023
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants