Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override JavaScript methods #4303

Open
cchidhu opened this issue Oct 22, 2023 · 1 comment
Open

Override JavaScript methods #4303

cchidhu opened this issue Oct 22, 2023 · 1 comment
Labels
bug This issue is a bug. p1

Comments

@cchidhu
Copy link

cchidhu commented Oct 22, 2023

Describe the bug

I have the following TypeScript class where one of the methods needs to be overridden in the implementation. I am ensuring this in the constructor.
image

Implementation of the above class in Python,
image

The foreign application implementing the above class is experiencing unexpected results even after the 'dummy_green_method' is overridden in the implementation. I expect the super constructor not to throw an error in the implementation because the method has been overridden. However, this is not the case. Please provide guidance on what I might be missing here.

Expected Behavior

The above implementation should throw an error while declaring an object.

Current Behavior

It's throwing an error because in the base constructor dummy_green_method is not overridden.

Reproduction Steps

Provided in the problem description.

Possible Solution

No response

Additional Information/Context

No response

SDK version used

1.69.0

Environment details (OS name and version, etc.)

macOS/13.6 (22G120)

@cchidhu cchidhu added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 22, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Apr 9, 2024

I suspect this might not be possible as described here: https://aws.github.io/jsii/user-guides/language-support/callbacks/
However the case is definitely not clearly described in the docs. Needs checking.

@mrgrain mrgrain added p1 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1
Projects
None yet
Development

No branches or pull requests

2 participants