Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New .NET Generator with new expected files #567

Merged
merged 20 commits into from
Aug 1, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 1, 2019

(Resubmitting because of a premature merge)

Needs at least this bugfix applied, and potentially more:

4926bfd


Hi,

This contains a new generator for .NET written in typescript with the new expected files
This also removes of the old generator codebase.

Fixes #463
Fixes #528

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rix0rrr rix0rrr requested a review from a team as a code owner July 25, 2019 18:41
@assyadh
Copy link
Contributor

assyadh commented Jul 25, 2019

I am working on the merge from master + regen.

@RomainMuller RomainMuller added this to the Merge new .net code generator milestone Jul 30, 2019
@assyadh
Copy link
Contributor

assyadh commented Jul 31, 2019

The branch is now conflicting, I'll do a merge + conflict resolution + regen

Copy link
Contributor

@costleya costleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly the same code as before, and the changes made I am familiar with. Outputted test binaries work as expected. Approving.

@RomainMuller RomainMuller merged commit c03e078 into master Aug 1, 2019
@RomainMuller RomainMuller deleted the hamzaad/dotnet-generator-redux branch August 1, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup the old .NET generator code Implement calc .NET code generation
4 participants