BREAKING CHANGE: Adjust Metrics and Webhook service port to align wit…

…h pod ports (#4142) Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
aws · Jun 27, 2023 · 0d68775 · 0d68775
1 parent a473b92
commit 0d68775
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/charts/karpenter/templates/service.yaml b/charts/karpenter/templates/service.yaml
@@ -13,11 +13,11 @@ spec:
   type: ClusterIP
   ports:
     - name: http-metrics
-      port: 8000
+      port: {{ .Values.controller.metrics.port }}
       targetPort: http-metrics
       protocol: TCP
     - name: https-webhook
-      port: 443
+      port: {{ .Values.webhook.port }}
       targetPort: https-webhook
       protocol: TCP
   selector:

diff --git a/website/content/en/preview/upgrade-guide.md b/website/content/en/preview/upgrade-guide.md
@@ -103,7 +103,7 @@ Snapshot releases are tagged with the git commit hash prefixed by the Karpenter
 ## Released Upgrade Notes
 
 ### Upgrading to v0.29.0+
-* Karpenter has changed the default metrics service port from 8080 to 8000. In `v0.28.0`, the Karpenter pod port was changed to 8000, but referenced the service by name, allowing users to scrape the service at port 8080 for metrics. `v0.29.0` aligns the two ports so that default service and default pod metrics ports are the same.
+* Karpenter has changed the default metrics service port from 8080 to 8000 and the default webhook service port from 443 to 8443. In `v0.28.0`, the Karpenter pod port was changed to 8000, but referenced the service by name, allowing users to scrape the service at port 8080 for metrics. `v0.29.0` aligns the two ports so that service and pod metrics ports are the same. These ports are set by the `controller.metrics.port` and `webhook.port` helm chart values, so if you have previously set these to non-default values, you may need to update your Prometheus scraper to match these new values.
 
 ### Upgrading to v0.28.0+