Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Adjust Metrics and Webhook service port to align with pod ports #4142

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jun 26, 2023

Description

  • Fixed an issue were we see that metrics and Webhook ports were not able to configured.

How was this change tested?

  • Manually tested

Does this change impact docs?

  • [] Yes, PR includes docs updates
  • [] Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner June 26, 2023 23:19
@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 0320300
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/649a32db4cc60a00089f9ef5
😎 Deploy Preview https://deploy-preview-4142--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@engedaam engedaam force-pushed the setting_webhooks_metrics_ports branch from d7ebc93 to 3d1dfd4 Compare June 26, 2023 23:20
@engedaam engedaam changed the title fix: Configure Metrics and Webhook ports chore: Configure Metrics and Webhook ports Jun 26, 2023
njtran
njtran previously approved these changes Jun 26, 2023
@engedaam engedaam changed the title chore: Configure Metrics and Webhook ports chore: Adjust Metrics and Webhook service port to align with pod ports Jun 26, 2023
@engedaam engedaam force-pushed the setting_webhooks_metrics_ports branch from 2772ca3 to 69f2761 Compare June 26, 2023 23:55
@engedaam engedaam force-pushed the setting_webhooks_metrics_ports branch from 69f2761 to 8809ca1 Compare June 27, 2023 00:13
@engedaam engedaam changed the title chore: Adjust Metrics and Webhook service port to align with pod ports BREAKING CHANGE: Adjust Metrics and Webhook service port to align with pod ports Jun 27, 2023
jonathan-innis
jonathan-innis previously approved these changes Jun 27, 2023
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) June 27, 2023 00:53
@jonathan-innis jonathan-innis merged commit 0d68775 into aws:main Jun 27, 2023
13 checks passed
@engedaam engedaam deleted the setting_webhooks_metrics_ports branch June 27, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants