-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: Adjust Metrics and Webhook service port to align with pod ports #4142
Merged
jonathan-innis
merged 3 commits into
aws:main
from
engedaam:setting_webhooks_metrics_ports
Jun 27, 2023
Merged
BREAKING CHANGE: Adjust Metrics and Webhook service port to align with pod ports #4142
jonathan-innis
merged 3 commits into
aws:main
from
engedaam:setting_webhooks_metrics_ports
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
engedaam
force-pushed
the
setting_webhooks_metrics_ports
branch
from
June 26, 2023 23:20
d7ebc93
to
3d1dfd4
Compare
engedaam
changed the title
fix: Configure Metrics and Webhook ports
chore: Configure Metrics and Webhook ports
Jun 26, 2023
njtran
previously approved these changes
Jun 26, 2023
engedaam
changed the title
chore: Configure Metrics and Webhook ports
chore: Adjust Metrics and Webhook service port to align with pod ports
Jun 26, 2023
engedaam
force-pushed
the
setting_webhooks_metrics_ports
branch
from
June 26, 2023 23:55
2772ca3
to
69f2761
Compare
engedaam
force-pushed
the
setting_webhooks_metrics_ports
branch
from
June 27, 2023 00:13
69f2761
to
8809ca1
Compare
engedaam
changed the title
chore: Adjust Metrics and Webhook service port to align with pod ports
BREAKING CHANGE: Adjust Metrics and Webhook service port to align with pod ports
Jun 27, 2023
jonathan-innis
previously approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
engedaam
force-pushed
the
setting_webhooks_metrics_ports
branch
from
June 27, 2023 00:52
4340676
to
0320300
Compare
jonathan-innis
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.