docs: Describe cloudformation.yaml for docs #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sftim
reviewed
Aug 18, 2023
There was a problem hiding this comment.
I've added some basic feedback.
@chrisnegus if you'd like a more detailed review, get in touch (via the Kubernetes Slack, or by email)
jonathan-innis
force-pushed
the
docs-migrate-to-karpenter
branch
from
a6393ff
to
4261c87
Compare
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
chrisnegus
force-pushed
the
docs-migrate-to-karpenter
branch
from
4261c87
to
95221eb
Compare
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
3 tasks
jonathan-innis
force-pushed
the
docs-migrate-to-karpenter
branch
5 times, most recently
from
ccec27b
to
f8e90ad
Compare
jonathan-innis
force-pushed
the
docs-migrate-to-karpenter
branch
from
f8e90ad
to
0f1b8c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds new documentation describing how CloudFormation is used to setup permissions needed by Karpenter to manage cloud and EKS resources. This is part of a larger effort to describe Karpenter requirements for those migrating existing clusters to use Karpenter.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.