docs: Update CloudFormation to handle v1beta1 permissions #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jonathan-innis
force-pushed
the
v1beta1-cloudformation
branch
5 times, most recently
from
af73411
to
e3ac33b
Compare
|
Snapshot successfully published to |
jonathan-innis
force-pushed
the
v1beta1-cloudformation
branch
from
e3ac33b
to
61c4fa5
Compare
|
Snapshot successfully published to |
chrisnegus
reviewed
Oct 8, 2023
There was a problem hiding this comment.
The cloudformation.yaml file looks good to me. I'll update my PR to match the new contents of that file: #4394
jonathan-innis
force-pushed
the
v1beta1-cloudformation
branch
from
61c4fa5
to
e8868cb
Compare
|
Snapshot successfully published to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Updates the CloudFormation template shipped with the Getting Started guide to use v1beta1 permissions. This also ensures that we are deploying the Karpenter controller IAM permissions with an additional policy that gives the controller the alpha permissions so that we can ensure that scenarios that are testing alpha and beta simultaneously will work.
How was this change tested?
make applywith the new permissionsDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.