Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move tests out from integration suite #6242

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

jigisha620
Copy link
Contributor

@jigisha620 jigisha620 commented May 20, 2024

Fixes #N/A

Description
This PR moves some tests out from integration test suite to separate test suites in an attempt to reduce the time taken by integration test suite to finish running. With these changes the time taken by the following suites to finish is -

  1. Integration - 1h13m
  2. AMI - 22m
  3. Storage - 14m
  4. Scheduling - 34m

How was this change tested?
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner May 20, 2024 10:25
@jigisha620 jigisha620 requested a review from bwagner5 May 20, 2024 10:25
Copy link

netlify bot commented May 20, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2230395
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66677ea0fc5efe00083fdd3e

@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 9456466752

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 82.474%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 9455586426: -0.05%
Covered Lines: 5553
Relevant Lines: 6733

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have few nits

test/suites/ami/ami_test.go Outdated Show resolved Hide resolved
test/suites/ami/ami_test.go Outdated Show resolved Hide resolved
test/suites/scheduling/scheduling_test.go Outdated Show resolved Hide resolved
test/suites/storage/storage_test.go Outdated Show resolved Hide resolved
test/suites/storage/storage_test.go Outdated Show resolved Hide resolved
test/suites/scheduling/scheduling_test.go Outdated Show resolved Hide resolved
.github/workflows/e2e-upgrade.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-matrix.yaml Outdated Show resolved Hide resolved
test/suites/ami/ami_test.go Outdated Show resolved Hide resolved
test/suites/scheduling/scheduling_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 531d7e0 into aws:main Jun 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants