Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group encoding packages under common namespace to improve shared logic #126

Closed
jasdel opened this issue Aug 4, 2020 · 1 comment
Closed

Comments

@jasdel
Copy link
Contributor

jasdel commented Aug 4, 2020

It would be helpful if the encoding packages like json, xml, query, etc, where grouped under a common encoding pkg. This makes it easier for these packages to have a common internal pkg containing shared behavior such as encodeFloat.

Propose a pkg refactor similar to:

/smithy-go
     /encoding
          /json
          /xml
          /query
          /httpbinding (aka rest)
          /eventstream
          /...
          /internal
               /float.go
               /...
      /transport
          /http
          /mqtt
          /eventstream
          /...
@jasdel jasdel added this to the v1.0 Release Candidate milestone Nov 13, 2020
@jasdel
Copy link
Contributor Author

jasdel commented Dec 17, 2020

Fixed in, #242

@jasdel jasdel closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant