Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

OCI Artifact page improvements #32

Closed
rikatz opened this issue Sep 3, 2020 · 2 comments
Closed

OCI Artifact page improvements #32

rikatz opened this issue Sep 3, 2020 · 2 comments
Assignees

Comments

@rikatz
Copy link

rikatz commented Sep 3, 2020

Couldn't find the markdown of the OCI Artifact pages, so opening an issue here:

  • Step 5.b should be:
helm create mychart
rm -rf ./mychart/templates/*

(It either needs a leading . before the /mychart, or turn /mychart into mychart/templates/*)

  • Step 2 or 3 - Create some environment variables to be used later in the registry creation and pushing:
export REGION=$(aws configure get region)
export ACCOUNT_ID=$(aws sts get-caller-identity --output text --query Account)
  • After exporting the variables above, step 4 (and all that references either REGION and/or ACCOUNT) can be replaced as the following:
aws ecr get-login-password \
     --region ${REGION} | helm registry login \
     --username AWS \
     --password-stdin ${ACCOUNT_ID}.dkr.ecr.${REGION}.amazonaws.com

and

helm chart save . ${ACCOUNT_ID}.dkr.ecr.${REGION}.amazonaws.com/artifact-test:mychart

(there are other parts in the text that can be replaced)

@rikatz
Copy link
Author

rikatz commented Sep 3, 2020

cc @joelbrandenburg

@joelbrandenburg joelbrandenburg self-assigned this Sep 3, 2020
@joelbrandenburg
Copy link
Contributor

The repository has been updated to include the latest changes to the Amazon ECR User Guide. I've fixed the typo you describe in step 5.b. I also realize that using environment variables is helpful but we generally don't use that style in the documentation so I left that out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants