don't set default cgroup option if reserved-cpus provided via kubelet… #1405

raghs-aws · 2023-08-25T15:28:10Z

… args

Issue #, if available:
Kubelet fails to start with --reserved-cpus argument due to conflict with system-reserved-cgroups being always specified in the kubelet configuration file. Bootstrap.sh shall allow use of reserved-cpus argument since that option is required for telco NFV workloads. Per k8s official documentation:

This option is specifically designed for Telco/NFV use cases where uncontrolled interrupts/timers may impact the workload performance. you can use this option to define the explicit cpuset for the system/kubernetes daemons as well as the interrupts/timers, so the rest CPUs on the system can be used exclusively for workloads, with less impact from uncontrolled interrupts/timers.

Description of changes:
Change is made to look for --reserved-cpus options in KUBELET_EXTRA_ARGS. If reserved-cpus are requested then don't set systemReservedCgroup and kubeReservedCgroup, as reserved cpus will reserve the cpus for system and kube.
if the --reserved-cpus parameter is not present then the default handling would be retained which will allow setting kubeReservedCgroup and kubeReservedCgroup

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

Yes, validated with and without --reserved-cpus in kubelet-extra-args.

Launch self managed EKS worker node group using latest EKS AMI (post Jan 2023) which sets systemReservedCgroup and kubeReservedCgroup in the kubelet configuration file by default. Add --reserved-cpus flag to BootstrapArguments for the node group. Kubelet will fail to start, if the above changes are not added. Once the changes are added as per this PR, the kubelet will come up with reserved-cpus.

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

… args

nebm-aws

Looks good. Tested with karpenter.

nebm-aws

looks good.

cartermckinnon · 2023-08-26T00:42:28Z

/ci launch

github-actions · 2023-08-26T00:43:00Z

@cartermckinnon roger that! I've dispatched a workflow. 👍

github-actions · 2023-08-26T01:10:37Z

@cartermckinnon the workflow that you requested has completed. 🎉

Kubernetes version	Build	Launch	Test
1.23	success ✅	success ✅	skipped ⏭️
1.24	success ✅	success ✅	skipped ⏭️
1.25	success ✅	success ✅	skipped ⏭️
1.26	success ✅	success ✅	skipped ⏭️
1.27	success ✅	success ✅	skipped ⏭️

raghs-aws · 2023-08-28T18:19:54Z

@cartermckinnon what are the next steps, I see that PR is open as code is not merged and is pending an review. Let me know, if there is anything else I need to trigger.

cartermckinnon · 2023-08-28T18:24:17Z

You'll need to fix the unit tests because of the change in behavior, and please add a new test for this. The linter also failed, so run make fmt.

cartermckinnon

Few small things.

files/bootstrap.sh

test/cases/reserved-cpus-kubelet-arg.sh

Co-authored-by: Carter <cartermckinnon@gmail.com>

Committer: raghs-aws

cartermckinnon · 2023-08-30T14:42:34Z

files/bootstrap.sh

@@ -222,6 +222,13 @@ ENABLE_LOCAL_OUTPOST="${ENABLE_LOCAL_OUTPOST:-}"
 CLUSTER_ID="${CLUSTER_ID:-}"
 LOCAL_DISKS="${LOCAL_DISKS:-}"

+##allow --reserved-cpus options via kubelet arg directly and not set default cgroup option
+USE_RESERVED_CPUS=false


I think we should invert the semantics of this variable, to disable the cgroup settings (e.g. USE_RESERVED_CGROUPS) instead of enabling reserved CPU's. Other than that, this PR LGTM.

makes sense, this way if we have some other usecases which needs disabling of cgroup, then we can reuse the same variable. let me push the changes,

cartermckinnon · 2023-08-30T16:27:47Z

@raghs-aws you need to make your test case script executable (chmod +x). Run make test to check locally.

raghs-aws · 2023-08-30T16:41:42Z

@raghs-aws you need to make your test case script executable (chmod +x). Run make test to check locally.

somehow the script got duplicated the original one passed but the copy didnt have the +x, I will delete that test case file.

raghs-aws · 2023-08-30T17:12:14Z

@raghs-aws you need to make your test case script executable (chmod +x). Run make test to check locally.

@raghs-aws you need to make your test case script executable (chmod +x). Run make test to check locally.

somehow the script got duplicated the original one passed but the copy didnt have the +x, I will delete that test case file.
Deleted the offending duplicate file and pushed the changes

* Update CHANGELOG.md for v20230703 AMI release (awslabs#1337) * Update CHANGELOG.md for v20230703 AMI release * Update CHANGELOG.md Co-authored-by: Carter <mckdev@amazon.com> * Update CHANGELOG.md --------- Co-authored-by: Carter <mckdev@amazon.com> * Update CHANGELOG.md (awslabs#1338) * Add logging for aws managed csi drivers (awslabs#1336) * Update CHANGELOG.md latest AMI release notes to highlight this was last 1.22 AMI (awslabs#1342) * Removing 1.22 from Makefile (awslabs#1343) * Generate version info for cached images only when is active (awslabs#1341) * Remove region names from us-iso/us-isob credential provider config (awslabs#1344) * Amazon Linux 2023 proof-of-concept (awslabs#1340) * Remove hardcoded pull_cni_from_github var (awslabs#1346) * Remove sonobuoy_e2e_registry (awslabs#1249) * Revert "avoid hard coding provisioner index array" (awslabs#1347) This reverts commit 6c16765. Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Update sync-eni-max-pods.yaml role ARN (awslabs#1350) * Add CodeCommit sync action (awslabs#1351) * update core CNI plugins version (awslabs#1308) * Update internal build config (awslabs#1353) * Update binary references (awslabs#1355) * Update CHANGELOG.md for 20230711 AMI release (awslabs#1357) * Enable discard_unpacked_layers by default (awslabs#1360) * Mount bpffs on all supported Kubernetes versions (awslabs#1349) * Cleanup /var/log/audit (awslabs#1363) * Use GitHub bot user as committer/author (awslabs#1366) * Update eni-max-pods.txt (awslabs#1365) * Update CHANGELOG.md for 20230728 AMI release (awslabs#1371) * Update eni-max-pods.txt (awslabs#1373) Co-authored-by: GitHub <noreply@github.com> * Install latest amazon-ssm-agent from S3 (awslabs#1370) * Do not set KubeletCredentialProviders feature flag for 1.28+ (awslabs#1375) * Fix bug in var doc gen (awslabs#1378) * Generate docs for GitHub Pages (awslabs#1379) * Add write permissions to deploy-docs workflow (awslabs#1381) * Force-push docs to gh-pages (awslabs#1382) * Cache IMDS tokens per-user (awslabs#1386) * Install latest runc 1.1.* (awslabs#1384) * Update eni-max-pods.txt (awslabs#1388) * Update binary build dates (awslabs#1390) * Fetch new IMDS token for every request (awslabs#1395) * Update CHANGELOG for v20230816 (awslabs#1396) * Update eni-max-pods.txt (awslabs#1397) * Update Makefile with latest binaries (awslabs#1403) * Add CI bot (awslabs#1402) * Disable janitor in forks (awslabs#1407) * Add note about bot authorization (awslabs#1406) * noproxy for direct communication to apiserver and timeouts of 3 seconds (awslabs#1393) * Update CHANGELOG.md for 20230825 AMI release (awslabs#1408) * Update CHANGELOG.md for 20230825 AMI release --------- Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> * Allow --reserved-cpus kubelet arg to be used (awslabs#1405) * Install kernel-headers, kernel-devel (awslabs#1302) * Handle eventually-consistent PrivateDnsName (awslabs#1383) * Add .git-commit to archivebuild (awslabs#1411) * Use archivebuild-wrapper system (awslabs#1413) * Discover .git-commit from environment (awslabs#1418) * Update eni-max-pods.txt (awslabs#1423) Co-authored-by: GitHub <noreply@github.com> * Update eni-max-pods.txt (awslabs#1424) Co-authored-by: GitHub <noreply@github.com> * Require builder instance to use IMDSv2 (awslabs#1422) * Add release note config (awslabs#1426) * Update eni-max-pods.txt (awslabs#1429) Co-authored-by: GitHub <noreply@github.com> * Use 2023-09-14 binaries, add 1.28 target (awslabs#1431) * Update eni-max-pods.txt (awslabs#1432) Co-authored-by: GitHub <noreply@github.com> * Set pid_max to 4194304 (awslabs#1434) * Install nerdctl (awslabs#1321) * Update CHANGELOG.md for 20230919 AMI release (awslabs#1439) * Update CHANGELOG.md for 20230919 AMI release Co-authored-by: Carter <cartermckinnon@gmail.com> --------- Co-authored-by: Carter <cartermckinnon@gmail.com> * bump latest Kubernetes build target version (awslabs#1440) * fix: Tag cached image with the ECR URI for the target region (awslabs#1442) * Add H100 into gpu clock (awslabs#1447) * bug: incorrect region variable name (awslabs#1449) Co-authored-by: ljosyula <ljosyula@amazon.com> * Update eni-max-pods.txt (awslabs#1452) Co-authored-by: GitHub <noreply@github.com> * Update CHANGELOG.md for 20231002 AMI release (awslabs#1456) Co-authored-by: ljosyula <ljosyula@amazon.com> * Build with latest binaries by default (awslabs#1391) * Fix region in cached image names (awslabs#1461) * Add 1.28 to CI (awslabs#1464) * Add optional FIPS support (awslabs#1458) * Set remote_folder on all shell provisioners (awslabs#1462) * Pull eksctl supported versions for CI (awslabs#1465) * remove kubernetes versions file and use eksctl supported version list * recognize compression Co-authored-by: Carter <cartermckinnon@gmail.com> --------- Co-authored-by: Carter <cartermckinnon@gmail.com> * Add CHANGELOG entry placeholder (awslabs#1466) * Add named arguments to bot commands (awslabs#1463) * get-ecr-uri.sh falls back to use another region in partition if region unconfigured (awslabs#1468) * Force delete CI clusters, don't wait for pod eviction (awslabs#1472) * Add CHANGELOG workflow for new releases (awslabs#1467) * Allow more flexible kernel_version (awslabs#1469) * Add r7i to eni-max-pods.txt (awslabs#1473) Co-authored-by: GitHub <noreply@github.com> * Fix containerd slice configuration (awslabs#1437) * Correctly tag cached images for us-gov-west-1 FIPS endpoint (awslabs#1476) * Lint space errors (awslabs#1121) * Ignore commit to address space errors (awslabs#1478) * Collect more info about Amazon VPC CNI (awslabs#1245) * Update eni-max-pods.txt (awslabs#1485) Co-authored-by: GitHub <noreply@github.com> * Fail fast if we cannot determine kubelet version (awslabs#1484) kubelet is likely to fail when there is a mismatch with GLIBC that is in the image vs the one golang uses to build the kubelet. So fail the image right away when this happens as this specific kubelet binary will NOT work in any instance started with this image. ``` 2023-10-25T10:11:38-04:00: amazon-ebs: kubelet: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by kubelet) 2023-10-25T10:11:38-04:00: amazon-ebs: kubelet: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by kubelet) ``` Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Persist CI version-info.json as artifact (awslabs#1493) * Add new i4i sizes to eni-max-pods.txt (awslabs#1495) Co-authored-by: GitHub <noreply@github.com> * Update eni-max-pods.txt (awslabs#1497) Co-authored-by: GitHub <noreply@github.com> * Drop the FIPS related provisioners for al2023 (awslabs#1499) Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Set nerdctl default namespace to k8s.io (awslabs#1488) * Update CHANGELOG.md for release v20231027 (awslabs#1502) Co-authored-by: GitHub <noreply@github.com> * Skip installing amazon-ssm-agent if already present (awslabs#1501) * Exclude automated eni-max-pods.txt PR's from release notes (awslabs#1498) * Remove extraneous space character (awslabs#1505) * Update CHANGELOG.md (awslabs#1507) * Update CHANGELOG.md to fix docker version (awslabs#1511) * Update docker to the latest 20.10 version (awslabs#1510) * Changelog entry format tweaks (awslabs#1508) * Document how to collect UserData (awslabs#1504) * Update Fluence changelog * Update what kubernetes ami will be build --------- Signed-off-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Xavier Ryan <108886506+xr1776@users.noreply.github.com> Co-authored-by: Carter <mckdev@amazon.com> Co-authored-by: jacobwolfaws <113703057+jacobwolfaws@users.noreply.github.com> Co-authored-by: Prasad Shende <prasad0896@users.noreply.github.com> Co-authored-by: camrakin <113552683+camrakin@users.noreply.github.com> Co-authored-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Jeffrey Nelson <jdnelson@amazon.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sichaow <sichaow@amazon.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Vincent Marguerie <24724195+vincentmrg@users.noreply.github.com> Co-authored-by: Andrew Johnstone <andrew@ajohnstone.com> Co-authored-by: Vela WU <50354807+wwvela@users.noreply.github.com> Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> Co-authored-by: Raghvendra Singh <90425886+raghs-aws@users.noreply.github.com> Co-authored-by: Matthew Wong <mattwon@amazon.com> Co-authored-by: Nick Baker <ndbaker1@outlook.com> Co-authored-by: ddl-retornam <56278673+ddl-retornam@users.noreply.github.com> Co-authored-by: Carter <cartermckinnon@gmail.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> Co-authored-by: Laxmi Soumya Josyula <42261978+ljosyula@users.noreply.github.com> Co-authored-by: ljosyula <ljosyula@amazon.com> Co-authored-by: Alex Schultz <aschultz@clumio.com> Co-authored-by: Julien Baladier <julienbaladier@users.noreply.github.com> Co-authored-by: Matt <merkes@amazon.com> Co-authored-by: Zoltán Reegn <zoltan.reegn@gmail.com> Co-authored-by: donovanrost <donovan.rost@gmail.com> Co-authored-by: guessi <guessi@gmail.com> Co-authored-by: pjaudiomv <34245618+pjaudiomv@users.noreply.github.com> Co-authored-by: Edmond Ceausu <eceausu@amazon.com>

* Update CHANGELOG.md for v20230703 AMI release (awslabs#1337) * Update CHANGELOG.md for v20230703 AMI release * Update CHANGELOG.md Co-authored-by: Carter <mckdev@amazon.com> * Update CHANGELOG.md --------- Co-authored-by: Carter <mckdev@amazon.com> * Update CHANGELOG.md (awslabs#1338) * Add logging for aws managed csi drivers (awslabs#1336) * Update CHANGELOG.md latest AMI release notes to highlight this was last 1.22 AMI (awslabs#1342) * Removing 1.22 from Makefile (awslabs#1343) * Generate version info for cached images only when is active (awslabs#1341) * Remove region names from us-iso/us-isob credential provider config (awslabs#1344) * Amazon Linux 2023 proof-of-concept (awslabs#1340) * Remove hardcoded pull_cni_from_github var (awslabs#1346) * Remove sonobuoy_e2e_registry (awslabs#1249) * Revert "avoid hard coding provisioner index array" (awslabs#1347) This reverts commit 6c16765. Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Update sync-eni-max-pods.yaml role ARN (awslabs#1350) * Add CodeCommit sync action (awslabs#1351) * update core CNI plugins version (awslabs#1308) * Update internal build config (awslabs#1353) * Update binary references (awslabs#1355) * Update CHANGELOG.md for 20230711 AMI release (awslabs#1357) * Enable discard_unpacked_layers by default (awslabs#1360) * Mount bpffs on all supported Kubernetes versions (awslabs#1349) * Cleanup /var/log/audit (awslabs#1363) * Use GitHub bot user as committer/author (awslabs#1366) * Update eni-max-pods.txt (awslabs#1365) * Update CHANGELOG.md for 20230728 AMI release (awslabs#1371) * Update eni-max-pods.txt (awslabs#1373) Co-authored-by: GitHub <noreply@github.com> * Install latest amazon-ssm-agent from S3 (awslabs#1370) * Do not set KubeletCredentialProviders feature flag for 1.28+ (awslabs#1375) * Fix bug in var doc gen (awslabs#1378) * Generate docs for GitHub Pages (awslabs#1379) * Add write permissions to deploy-docs workflow (awslabs#1381) * Force-push docs to gh-pages (awslabs#1382) * Cache IMDS tokens per-user (awslabs#1386) * Install latest runc 1.1.* (awslabs#1384) * Update eni-max-pods.txt (awslabs#1388) * Update binary build dates (awslabs#1390) * Fetch new IMDS token for every request (awslabs#1395) * Update CHANGELOG for v20230816 (awslabs#1396) * Update eni-max-pods.txt (awslabs#1397) * Update Makefile with latest binaries (awslabs#1403) * Add CI bot (awslabs#1402) * Disable janitor in forks (awslabs#1407) * Add note about bot authorization (awslabs#1406) * noproxy for direct communication to apiserver and timeouts of 3 seconds (awslabs#1393) * Update CHANGELOG.md for 20230825 AMI release (awslabs#1408) * Update CHANGELOG.md for 20230825 AMI release --------- Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> * Allow --reserved-cpus kubelet arg to be used (awslabs#1405) * Install kernel-headers, kernel-devel (awslabs#1302) * Handle eventually-consistent PrivateDnsName (awslabs#1383) * Add .git-commit to archivebuild (awslabs#1411) * Use archivebuild-wrapper system (awslabs#1413) * Discover .git-commit from environment (awslabs#1418) * Update eni-max-pods.txt (awslabs#1423) Co-authored-by: GitHub <noreply@github.com> * Update eni-max-pods.txt (awslabs#1424) Co-authored-by: GitHub <noreply@github.com> * Require builder instance to use IMDSv2 (awslabs#1422) * Add release note config (awslabs#1426) * Update eni-max-pods.txt (awslabs#1429) Co-authored-by: GitHub <noreply@github.com> * Use 2023-09-14 binaries, add 1.28 target (awslabs#1431) * Update eni-max-pods.txt (awslabs#1432) Co-authored-by: GitHub <noreply@github.com> * Set pid_max to 4194304 (awslabs#1434) * Install nerdctl (awslabs#1321) * Update CHANGELOG.md for 20230919 AMI release (awslabs#1439) * Update CHANGELOG.md for 20230919 AMI release Co-authored-by: Carter <cartermckinnon@gmail.com> --------- Co-authored-by: Carter <cartermckinnon@gmail.com> * bump latest Kubernetes build target version (awslabs#1440) * fix: Tag cached image with the ECR URI for the target region (awslabs#1442) * Add H100 into gpu clock (awslabs#1447) * bug: incorrect region variable name (awslabs#1449) Co-authored-by: ljosyula <ljosyula@amazon.com> * Update eni-max-pods.txt (awslabs#1452) Co-authored-by: GitHub <noreply@github.com> * Update CHANGELOG.md for 20231002 AMI release (awslabs#1456) Co-authored-by: ljosyula <ljosyula@amazon.com> * Build with latest binaries by default (awslabs#1391) * Fix region in cached image names (awslabs#1461) * Add 1.28 to CI (awslabs#1464) * Add optional FIPS support (awslabs#1458) * Set remote_folder on all shell provisioners (awslabs#1462) * Pull eksctl supported versions for CI (awslabs#1465) * remove kubernetes versions file and use eksctl supported version list * recognize compression Co-authored-by: Carter <cartermckinnon@gmail.com> --------- Co-authored-by: Carter <cartermckinnon@gmail.com> * Add CHANGELOG entry placeholder (awslabs#1466) * Add named arguments to bot commands (awslabs#1463) * get-ecr-uri.sh falls back to use another region in partition if region unconfigured (awslabs#1468) * Force delete CI clusters, don't wait for pod eviction (awslabs#1472) * Add CHANGELOG workflow for new releases (awslabs#1467) * Allow more flexible kernel_version (awslabs#1469) * Add r7i to eni-max-pods.txt (awslabs#1473) Co-authored-by: GitHub <noreply@github.com> * Fix containerd slice configuration (awslabs#1437) * Correctly tag cached images for us-gov-west-1 FIPS endpoint (awslabs#1476) * Lint space errors (awslabs#1121) * Ignore commit to address space errors (awslabs#1478) * Collect more info about Amazon VPC CNI (awslabs#1245) * Update eni-max-pods.txt (awslabs#1485) Co-authored-by: GitHub <noreply@github.com> * Fail fast if we cannot determine kubelet version (awslabs#1484) kubelet is likely to fail when there is a mismatch with GLIBC that is in the image vs the one golang uses to build the kubelet. So fail the image right away when this happens as this specific kubelet binary will NOT work in any instance started with this image. ``` 2023-10-25T10:11:38-04:00: amazon-ebs: kubelet: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by kubelet) 2023-10-25T10:11:38-04:00: amazon-ebs: kubelet: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by kubelet) ``` Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Persist CI version-info.json as artifact (awslabs#1493) * Add new i4i sizes to eni-max-pods.txt (awslabs#1495) Co-authored-by: GitHub <noreply@github.com> * Update eni-max-pods.txt (awslabs#1497) Co-authored-by: GitHub <noreply@github.com> * Drop the FIPS related provisioners for al2023 (awslabs#1499) Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Set nerdctl default namespace to k8s.io (awslabs#1488) * Update CHANGELOG.md for release v20231027 (awslabs#1502) Co-authored-by: GitHub <noreply@github.com> * Skip installing amazon-ssm-agent if already present (awslabs#1501) * Exclude automated eni-max-pods.txt PR's from release notes (awslabs#1498) * Remove extraneous space character (awslabs#1505) * Update CHANGELOG.md (awslabs#1507) * Update CHANGELOG.md to fix docker version (awslabs#1511) * Update docker to the latest 20.10 version (awslabs#1510) * Changelog entry format tweaks (awslabs#1508) * Document how to collect UserData (awslabs#1504) * Update eni-max-pods.txt (awslabs#1518) Co-authored-by: GitHub <noreply@github.com> * Update CHANGELOG.md for release v20231116 (awslabs#1521) Co-authored-by: GitHub <noreply@github.com> * Add check for ecr-fips endpoint availability (awslabs#1524) * Miscellaneous fixes from AL2023 testing (awslabs#1528) Signed-off-by: Davanum Srinivas <davanum@gmail.com> * fix Permission denied for 99-default.link (awslabs#1529) Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Install SSM agent from AL core repo by default (awslabs#1531) * Update to `containerd` 1.7 (awslabs#1516) * Capture logs for EKS Pod Identity Agent (awslabs#1533) * change how aws cli is installed * Update CHANGELOG.md for release v20231201 (awslabs#1538) Co-authored-by: GitHub <noreply@github.com> * AL2023 networking changes for VPC CNI compatibility (awslabs#1539) * Set containerd LimitNOFILE to recommended value (awslabs#1535) * fix networkd settings (awslabs#1540) * Update get-ecr-uri.sh with ca-west-1 account (awslabs#1542) * Install amazon packer plugin for CI (awslabs#1545) * Fix flag typo in logging (awslabs#1547) * Update CHANGELOG.md for release v20231220 (awslabs#1550) Co-authored-by: GitHub <noreply@github.com> * Revert "Set containerd LimitNOFILE to recommended value (awslabs#1535)" (awslabs#1552) This reverts commit e098953. * set ssm_agent_version after updating from upstream * Uncomment filtering for circle ci config --------- Signed-off-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Xavier Ryan <108886506+xr1776@users.noreply.github.com> Co-authored-by: Carter <mckdev@amazon.com> Co-authored-by: jacobwolfaws <113703057+jacobwolfaws@users.noreply.github.com> Co-authored-by: Prasad Shende <prasad0896@users.noreply.github.com> Co-authored-by: camrakin <113552683+camrakin@users.noreply.github.com> Co-authored-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Jeffrey Nelson <jdnelson@amazon.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sichaow <sichaow@amazon.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Vincent Marguerie <24724195+vincentmrg@users.noreply.github.com> Co-authored-by: Andrew Johnstone <andrew@ajohnstone.com> Co-authored-by: Vela WU <50354807+wwvela@users.noreply.github.com> Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> Co-authored-by: Raghvendra Singh <90425886+raghs-aws@users.noreply.github.com> Co-authored-by: Matthew Wong <mattwon@amazon.com> Co-authored-by: Nick Baker <ndbaker1@outlook.com> Co-authored-by: ddl-retornam <56278673+ddl-retornam@users.noreply.github.com> Co-authored-by: Carter <cartermckinnon@gmail.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> Co-authored-by: Laxmi Soumya Josyula <42261978+ljosyula@users.noreply.github.com> Co-authored-by: ljosyula <ljosyula@amazon.com> Co-authored-by: Alex Schultz <aschultz@clumio.com> Co-authored-by: Julien Baladier <julienbaladier@users.noreply.github.com> Co-authored-by: Matt <merkes@amazon.com> Co-authored-by: Zoltán Reegn <zoltan.reegn@gmail.com> Co-authored-by: donovanrost <donovan.rost@gmail.com> Co-authored-by: guessi <guessi@gmail.com> Co-authored-by: pjaudiomv <34245618+pjaudiomv@users.noreply.github.com> Co-authored-by: Edmond Ceausu <eceausu@amazon.com> Co-authored-by: Joe North <joseph@jnorth.me> Co-authored-by: Keto D. Zhang <keto.zhang@gmail.com>

* Merge with upstream v20231116 (#30) * Update CHANGELOG.md for v20230703 AMI release (awslabs#1337) * Update CHANGELOG.md for v20230703 AMI release * Update CHANGELOG.md Co-authored-by: Carter <mckdev@amazon.com> * Update CHANGELOG.md --------- Co-authored-by: Carter <mckdev@amazon.com> * Update CHANGELOG.md (awslabs#1338) * Add logging for aws managed csi drivers (awslabs#1336) * Update CHANGELOG.md latest AMI release notes to highlight this was last 1.22 AMI (awslabs#1342) * Removing 1.22 from Makefile (awslabs#1343) * Generate version info for cached images only when is active (awslabs#1341) * Remove region names from us-iso/us-isob credential provider config (awslabs#1344) * Amazon Linux 2023 proof-of-concept (awslabs#1340) * Remove hardcoded pull_cni_from_github var (awslabs#1346) * Remove sonobuoy_e2e_registry (awslabs#1249) * Revert "avoid hard coding provisioner index array" (awslabs#1347) This reverts commit 6c16765. Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Update sync-eni-max-pods.yaml role ARN (awslabs#1350) * Add CodeCommit sync action (awslabs#1351) * update core CNI plugins version (awslabs#1308) * Update internal build config (awslabs#1353) * Update binary references (awslabs#1355) * Update CHANGELOG.md for 20230711 AMI release (awslabs#1357) * Enable discard_unpacked_layers by default (awslabs#1360) * Mount bpffs on all supported Kubernetes versions (awslabs#1349) * Cleanup /var/log/audit (awslabs#1363) * Use GitHub bot user as committer/author (awslabs#1366) * Update eni-max-pods.txt (awslabs#1365) * Update CHANGELOG.md for 20230728 AMI release (awslabs#1371) * Update eni-max-pods.txt (awslabs#1373) Co-authored-by: GitHub <noreply@github.com> * Install latest amazon-ssm-agent from S3 (awslabs#1370) * Do not set KubeletCredentialProviders feature flag for 1.28+ (awslabs#1375) * Fix bug in var doc gen (awslabs#1378) * Generate docs for GitHub Pages (awslabs#1379) * Add write permissions to deploy-docs workflow (awslabs#1381) * Force-push docs to gh-pages (awslabs#1382) * Cache IMDS tokens per-user (awslabs#1386) * Install latest runc 1.1.* (awslabs#1384) * Update eni-max-pods.txt (awslabs#1388) * Update binary build dates (awslabs#1390) * Fetch new IMDS token for every request (awslabs#1395) * Update CHANGELOG for v20230816 (awslabs#1396) * Update eni-max-pods.txt (awslabs#1397) * Update Makefile with latest binaries (awslabs#1403) * Add CI bot (awslabs#1402) * Disable janitor in forks (awslabs#1407) * Add note about bot authorization (awslabs#1406) * noproxy for direct communication to apiserver and timeouts of 3 seconds (awslabs#1393) * Update CHANGELOG.md for 20230825 AMI release (awslabs#1408) * Update CHANGELOG.md for 20230825 AMI release --------- Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> * Allow --reserved-cpus kubelet arg to be used (awslabs#1405) * Install kernel-headers, kernel-devel (awslabs#1302) * Handle eventually-consistent PrivateDnsName (awslabs#1383) * Add .git-commit to archivebuild (awslabs#1411) * Use archivebuild-wrapper system (awslabs#1413) * Discover .git-commit from environment (awslabs#1418) * Update eni-max-pods.txt (awslabs#1423) Co-authored-by: GitHub <noreply@github.com> * Update eni-max-pods.txt (awslabs#1424) Co-authored-by: GitHub <noreply@github.com> * Require builder instance to use IMDSv2 (awslabs#1422) * Add release note config (awslabs#1426) * Update eni-max-pods.txt (awslabs#1429) Co-authored-by: GitHub <noreply@github.com> * Use 2023-09-14 binaries, add 1.28 target (awslabs#1431) * Update eni-max-pods.txt (awslabs#1432) Co-authored-by: GitHub <noreply@github.com> * Set pid_max to 4194304 (awslabs#1434) * Install nerdctl (awslabs#1321) * Update CHANGELOG.md for 20230919 AMI release (awslabs#1439) * Update CHANGELOG.md for 20230919 AMI release Co-authored-by: Carter <cartermckinnon@gmail.com> --------- Co-authored-by: Carter <cartermckinnon@gmail.com> * bump latest Kubernetes build target version (awslabs#1440) * fix: Tag cached image with the ECR URI for the target region (awslabs#1442) * Add H100 into gpu clock (awslabs#1447) * bug: incorrect region variable name (awslabs#1449) Co-authored-by: ljosyula <ljosyula@amazon.com> * Update eni-max-pods.txt (awslabs#1452) Co-authored-by: GitHub <noreply@github.com> * Update CHANGELOG.md for 20231002 AMI release (awslabs#1456) Co-authored-by: ljosyula <ljosyula@amazon.com> * Build with latest binaries by default (awslabs#1391) * Fix region in cached image names (awslabs#1461) * Add 1.28 to CI (awslabs#1464) * Add optional FIPS support (awslabs#1458) * Set remote_folder on all shell provisioners (awslabs#1462) * Pull eksctl supported versions for CI (awslabs#1465) * remove kubernetes versions file and use eksctl supported version list * recognize compression Co-authored-by: Carter <cartermckinnon@gmail.com> --------- Co-authored-by: Carter <cartermckinnon@gmail.com> * Add CHANGELOG entry placeholder (awslabs#1466) * Add named arguments to bot commands (awslabs#1463) * get-ecr-uri.sh falls back to use another region in partition if region unconfigured (awslabs#1468) * Force delete CI clusters, don't wait for pod eviction (awslabs#1472) * Add CHANGELOG workflow for new releases (awslabs#1467) * Allow more flexible kernel_version (awslabs#1469) * Add r7i to eni-max-pods.txt (awslabs#1473) Co-authored-by: GitHub <noreply@github.com> * Fix containerd slice configuration (awslabs#1437) * Correctly tag cached images for us-gov-west-1 FIPS endpoint (awslabs#1476) * Lint space errors (awslabs#1121) * Ignore commit to address space errors (awslabs#1478) * Collect more info about Amazon VPC CNI (awslabs#1245) * Update eni-max-pods.txt (awslabs#1485) Co-authored-by: GitHub <noreply@github.com> * Fail fast if we cannot determine kubelet version (awslabs#1484) kubelet is likely to fail when there is a mismatch with GLIBC that is in the image vs the one golang uses to build the kubelet. So fail the image right away when this happens as this specific kubelet binary will NOT work in any instance started with this image. ``` 2023-10-25T10:11:38-04:00: amazon-ebs: kubelet: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by kubelet) 2023-10-25T10:11:38-04:00: amazon-ebs: kubelet: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by kubelet) ``` Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Persist CI version-info.json as artifact (awslabs#1493) * Add new i4i sizes to eni-max-pods.txt (awslabs#1495) Co-authored-by: GitHub <noreply@github.com> * Update eni-max-pods.txt (awslabs#1497) Co-authored-by: GitHub <noreply@github.com> * Drop the FIPS related provisioners for al2023 (awslabs#1499) Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Set nerdctl default namespace to k8s.io (awslabs#1488) * Update CHANGELOG.md for release v20231027 (awslabs#1502) Co-authored-by: GitHub <noreply@github.com> * Skip installing amazon-ssm-agent if already present (awslabs#1501) * Exclude automated eni-max-pods.txt PR's from release notes (awslabs#1498) * Remove extraneous space character (awslabs#1505) * Update CHANGELOG.md (awslabs#1507) * Update CHANGELOG.md to fix docker version (awslabs#1511) * Update docker to the latest 20.10 version (awslabs#1510) * Changelog entry format tweaks (awslabs#1508) * Document how to collect UserData (awslabs#1504) * Update Fluence changelog * Update what kubernetes ami will be build --------- Signed-off-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Xavier Ryan <108886506+xr1776@users.noreply.github.com> Co-authored-by: Carter <mckdev@amazon.com> Co-authored-by: jacobwolfaws <113703057+jacobwolfaws@users.noreply.github.com> Co-authored-by: Prasad Shende <prasad0896@users.noreply.github.com> Co-authored-by: camrakin <113552683+camrakin@users.noreply.github.com> Co-authored-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Jeffrey Nelson <jdnelson@amazon.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sichaow <sichaow@amazon.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Vincent Marguerie <24724195+vincentmrg@users.noreply.github.com> Co-authored-by: Andrew Johnstone <andrew@ajohnstone.com> Co-authored-by: Vela WU <50354807+wwvela@users.noreply.github.com> Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> Co-authored-by: Raghvendra Singh <90425886+raghs-aws@users.noreply.github.com> Co-authored-by: Matthew Wong <mattwon@amazon.com> Co-authored-by: Nick Baker <ndbaker1@outlook.com> Co-authored-by: ddl-retornam <56278673+ddl-retornam@users.noreply.github.com> Co-authored-by: Carter <cartermckinnon@gmail.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> Co-authored-by: Laxmi Soumya Josyula <42261978+ljosyula@users.noreply.github.com> Co-authored-by: ljosyula <ljosyula@amazon.com> Co-authored-by: Alex Schultz <aschultz@clumio.com> Co-authored-by: Julien Baladier <julienbaladier@users.noreply.github.com> Co-authored-by: Matt <merkes@amazon.com> Co-authored-by: Zoltán Reegn <zoltan.reegn@gmail.com> Co-authored-by: donovanrost <donovan.rost@gmail.com> Co-authored-by: guessi <guessi@gmail.com> Co-authored-by: pjaudiomv <34245618+pjaudiomv@users.noreply.github.com> Co-authored-by: Edmond Ceausu <eceausu@amazon.com> * Add awscli to build step (#31) * Update CHANGELOG.md for v20230703 AMI release (awslabs#1337) * Update CHANGELOG.md for v20230703 AMI release * Update CHANGELOG.md Co-authored-by: Carter <mckdev@amazon.com> * Update CHANGELOG.md --------- Co-authored-by: Carter <mckdev@amazon.com> * Update CHANGELOG.md (awslabs#1338) * Add logging for aws managed csi drivers (awslabs#1336) * Update CHANGELOG.md latest AMI release notes to highlight this was last 1.22 AMI (awslabs#1342) * Removing 1.22 from Makefile (awslabs#1343) * Generate version info for cached images only when is active (awslabs#1341) * Remove region names from us-iso/us-isob credential provider config (awslabs#1344) * Amazon Linux 2023 proof-of-concept (awslabs#1340) * Remove hardcoded pull_cni_from_github var (awslabs#1346) * Remove sonobuoy_e2e_registry (awslabs#1249) * Revert "avoid hard coding provisioner index array" (awslabs#1347) This reverts commit 6c16765. Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Update sync-eni-max-pods.yaml role ARN (awslabs#1350) * Add CodeCommit sync action (awslabs#1351) * update core CNI plugins version (awslabs#1308) * Update internal build config (awslabs#1353) * Update binary references (awslabs#1355) * Update CHANGELOG.md for 20230711 AMI release (awslabs#1357) * Enable discard_unpacked_layers by default (awslabs#1360) * Mount bpffs on all supported Kubernetes versions (awslabs#1349) * Cleanup /var/log/audit (awslabs#1363) * Use GitHub bot user as committer/author (awslabs#1366) * Update eni-max-pods.txt (awslabs#1365) * Update CHANGELOG.md for 20230728 AMI release (awslabs#1371) * Update eni-max-pods.txt (awslabs#1373) Co-authored-by: GitHub <noreply@github.com> * Install latest amazon-ssm-agent from S3 (awslabs#1370) * Do not set KubeletCredentialProviders feature flag for 1.28+ (awslabs#1375) * Fix bug in var doc gen (awslabs#1378) * Generate docs for GitHub Pages (awslabs#1379) * Add write permissions to deploy-docs workflow (awslabs#1381) * Force-push docs to gh-pages (awslabs#1382) * Cache IMDS tokens per-user (awslabs#1386) * Install latest runc 1.1.* (awslabs#1384) * Update eni-max-pods.txt (awslabs#1388) * Update binary build dates (awslabs#1390) * Fetch new IMDS token for every request (awslabs#1395) * Update CHANGELOG for v20230816 (awslabs#1396) * Update eni-max-pods.txt (awslabs#1397) * Update Makefile with latest binaries (awslabs#1403) * Add CI bot (awslabs#1402) * Disable janitor in forks (awslabs#1407) * Add note about bot authorization (awslabs#1406) * noproxy for direct communication to apiserver and timeouts of 3 seconds (awslabs#1393) * Update CHANGELOG.md for 20230825 AMI release (awslabs#1408) * Update CHANGELOG.md for 20230825 AMI release --------- Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> * Allow --reserved-cpus kubelet arg to be used (awslabs#1405) * Install kernel-headers, kernel-devel (awslabs#1302) * Handle eventually-consistent PrivateDnsName (awslabs#1383) * Add .git-commit to archivebuild (awslabs#1411) * Use archivebuild-wrapper system (awslabs#1413) * Discover .git-commit from environment (awslabs#1418) * Update eni-max-pods.txt (awslabs#1423) Co-authored-by: GitHub <noreply@github.com> * Update eni-max-pods.txt (awslabs#1424) Co-authored-by: GitHub <noreply@github.com> * Require builder instance to use IMDSv2 (awslabs#1422) * Add release note config (awslabs#1426) * Update eni-max-pods.txt (awslabs#1429) Co-authored-by: GitHub <noreply@github.com> * Use 2023-09-14 binaries, add 1.28 target (awslabs#1431) * Update eni-max-pods.txt (awslabs#1432) Co-authored-by: GitHub <noreply@github.com> * Set pid_max to 4194304 (awslabs#1434) * Install nerdctl (awslabs#1321) * Update CHANGELOG.md for 20230919 AMI release (awslabs#1439) * Update CHANGELOG.md for 20230919 AMI release Co-authored-by: Carter <cartermckinnon@gmail.com> --------- Co-authored-by: Carter <cartermckinnon@gmail.com> * bump latest Kubernetes build target version (awslabs#1440) * fix: Tag cached image with the ECR URI for the target region (awslabs#1442) * Add H100 into gpu clock (awslabs#1447) * bug: incorrect region variable name (awslabs#1449) Co-authored-by: ljosyula <ljosyula@amazon.com> * Update eni-max-pods.txt (awslabs#1452) Co-authored-by: GitHub <noreply@github.com> * Update CHANGELOG.md for 20231002 AMI release (awslabs#1456) Co-authored-by: ljosyula <ljosyula@amazon.com> * Build with latest binaries by default (awslabs#1391) * Fix region in cached image names (awslabs#1461) * Add 1.28 to CI (awslabs#1464) * Add optional FIPS support (awslabs#1458) * Set remote_folder on all shell provisioners (awslabs#1462) * Pull eksctl supported versions for CI (awslabs#1465) * remove kubernetes versions file and use eksctl supported version list * recognize compression Co-authored-by: Carter <cartermckinnon@gmail.com> --------- Co-authored-by: Carter <cartermckinnon@gmail.com> * Add CHANGELOG entry placeholder (awslabs#1466) * Add named arguments to bot commands (awslabs#1463) * get-ecr-uri.sh falls back to use another region in partition if region unconfigured (awslabs#1468) * Force delete CI clusters, don't wait for pod eviction (awslabs#1472) * Add CHANGELOG workflow for new releases (awslabs#1467) * Allow more flexible kernel_version (awslabs#1469) * Add r7i to eni-max-pods.txt (awslabs#1473) Co-authored-by: GitHub <noreply@github.com> * Fix containerd slice configuration (awslabs#1437) * Correctly tag cached images for us-gov-west-1 FIPS endpoint (awslabs#1476) * Lint space errors (awslabs#1121) * Ignore commit to address space errors (awslabs#1478) * Collect more info about Amazon VPC CNI (awslabs#1245) * Update eni-max-pods.txt (awslabs#1485) Co-authored-by: GitHub <noreply@github.com> * Fail fast if we cannot determine kubelet version (awslabs#1484) kubelet is likely to fail when there is a mismatch with GLIBC that is in the image vs the one golang uses to build the kubelet. So fail the image right away when this happens as this specific kubelet binary will NOT work in any instance started with this image. ``` 2023-10-25T10:11:38-04:00: amazon-ebs: kubelet: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by kubelet) 2023-10-25T10:11:38-04:00: amazon-ebs: kubelet: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by kubelet) ``` Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Persist CI version-info.json as artifact (awslabs#1493) * Add new i4i sizes to eni-max-pods.txt (awslabs#1495) Co-authored-by: GitHub <noreply@github.com> * Update eni-max-pods.txt (awslabs#1497) Co-authored-by: GitHub <noreply@github.com> * Drop the FIPS related provisioners for al2023 (awslabs#1499) Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Set nerdctl default namespace to k8s.io (awslabs#1488) * Update CHANGELOG.md for release v20231027 (awslabs#1502) Co-authored-by: GitHub <noreply@github.com> * Skip installing amazon-ssm-agent if already present (awslabs#1501) * Exclude automated eni-max-pods.txt PR's from release notes (awslabs#1498) * Remove extraneous space character (awslabs#1505) * Update CHANGELOG.md (awslabs#1507) * Update CHANGELOG.md to fix docker version (awslabs#1511) * Update docker to the latest 20.10 version (awslabs#1510) * Changelog entry format tweaks (awslabs#1508) * Document how to collect UserData (awslabs#1504) * Update eni-max-pods.txt (awslabs#1518) Co-authored-by: GitHub <noreply@github.com> * Update CHANGELOG.md for release v20231116 (awslabs#1521) Co-authored-by: GitHub <noreply@github.com> * Add check for ecr-fips endpoint availability (awslabs#1524) * Miscellaneous fixes from AL2023 testing (awslabs#1528) Signed-off-by: Davanum Srinivas <davanum@gmail.com> * fix Permission denied for 99-default.link (awslabs#1529) Signed-off-by: Davanum Srinivas <davanum@gmail.com> * Install SSM agent from AL core repo by default (awslabs#1531) * Update to `containerd` 1.7 (awslabs#1516) * Capture logs for EKS Pod Identity Agent (awslabs#1533) * change how aws cli is installed * Update CHANGELOG.md for release v20231201 (awslabs#1538) Co-authored-by: GitHub <noreply@github.com> * AL2023 networking changes for VPC CNI compatibility (awslabs#1539) * Set containerd LimitNOFILE to recommended value (awslabs#1535) * fix networkd settings (awslabs#1540) * Update get-ecr-uri.sh with ca-west-1 account (awslabs#1542) * Install amazon packer plugin for CI (awslabs#1545) * Fix flag typo in logging (awslabs#1547) * Update CHANGELOG.md for release v20231220 (awslabs#1550) Co-authored-by: GitHub <noreply@github.com> * Revert "Set containerd LimitNOFILE to recommended value (awslabs#1535)" (awslabs#1552) This reverts commit e098953. * set ssm_agent_version after updating from upstream * Uncomment filtering for circle ci config --------- Signed-off-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Xavier Ryan <108886506+xr1776@users.noreply.github.com> Co-authored-by: Carter <mckdev@amazon.com> Co-authored-by: jacobwolfaws <113703057+jacobwolfaws@users.noreply.github.com> Co-authored-by: Prasad Shende <prasad0896@users.noreply.github.com> Co-authored-by: camrakin <113552683+camrakin@users.noreply.github.com> Co-authored-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Jeffrey Nelson <jdnelson@amazon.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sichaow <sichaow@amazon.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Vincent Marguerie <24724195+vincentmrg@users.noreply.github.com> Co-authored-by: Andrew Johnstone <andrew@ajohnstone.com> Co-authored-by: Vela WU <50354807+wwvela@users.noreply.github.com> Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> Co-authored-by: Raghvendra Singh <90425886+raghs-aws@users.noreply.github.com> Co-authored-by: Matthew Wong <mattwon@amazon.com> Co-authored-by: Nick Baker <ndbaker1@outlook.com> Co-authored-by: ddl-retornam <56278673+ddl-retornam@users.noreply.github.com> Co-authored-by: Carter <cartermckinnon@gmail.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> Co-authored-by: Laxmi Soumya Josyula <42261978+ljosyula@users.noreply.github.com> Co-authored-by: ljosyula <ljosyula@amazon.com> Co-authored-by: Alex Schultz <aschultz@clumio.com> Co-authored-by: Julien Baladier <julienbaladier@users.noreply.github.com> Co-authored-by: Matt <merkes@amazon.com> Co-authored-by: Zoltán Reegn <zoltan.reegn@gmail.com> Co-authored-by: donovanrost <donovan.rost@gmail.com> Co-authored-by: guessi <guessi@gmail.com> Co-authored-by: pjaudiomv <34245618+pjaudiomv@users.noreply.github.com> Co-authored-by: Edmond Ceausu <eceausu@amazon.com> Co-authored-by: Joe North <joseph@jnorth.me> Co-authored-by: Keto D. Zhang <keto.zhang@gmail.com> --------- Signed-off-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Xavier Ryan <108886506+xr1776@users.noreply.github.com> Co-authored-by: Carter <mckdev@amazon.com> Co-authored-by: jacobwolfaws <113703057+jacobwolfaws@users.noreply.github.com> Co-authored-by: Prasad Shende <prasad0896@users.noreply.github.com> Co-authored-by: camrakin <113552683+camrakin@users.noreply.github.com> Co-authored-by: Davanum Srinivas <davanum@gmail.com> Co-authored-by: Jeffrey Nelson <jdnelson@amazon.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sichaow <sichaow@amazon.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Vincent Marguerie <24724195+vincentmrg@users.noreply.github.com> Co-authored-by: Andrew Johnstone <andrew@ajohnstone.com> Co-authored-by: Vela WU <50354807+wwvela@users.noreply.github.com> Co-authored-by: Vela WU <50354807+FerrelWallis@users.noreply.github.com> Co-authored-by: Raghvendra Singh <90425886+raghs-aws@users.noreply.github.com> Co-authored-by: Matthew Wong <mattwon@amazon.com> Co-authored-by: Nick Baker <ndbaker1@outlook.com> Co-authored-by: ddl-retornam <56278673+ddl-retornam@users.noreply.github.com> Co-authored-by: Carter <cartermckinnon@gmail.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com> Co-authored-by: Laxmi Soumya Josyula <42261978+ljosyula@users.noreply.github.com> Co-authored-by: ljosyula <ljosyula@amazon.com> Co-authored-by: Alex Schultz <aschultz@clumio.com> Co-authored-by: Julien Baladier <julienbaladier@users.noreply.github.com> Co-authored-by: Matt <merkes@amazon.com> Co-authored-by: Zoltán Reegn <zoltan.reegn@gmail.com> Co-authored-by: donovanrost <donovan.rost@gmail.com> Co-authored-by: guessi <guessi@gmail.com> Co-authored-by: pjaudiomv <34245618+pjaudiomv@users.noreply.github.com> Co-authored-by: Edmond Ceausu <eceausu@amazon.com> Co-authored-by: Joe North <joseph@jnorth.me> Co-authored-by: Keto D. Zhang <keto.zhang@gmail.com>

don't set default cgroup option if reserved-cpus provided via kubelet…

72f4f5a

… args

raghs-aws closed this Aug 25, 2023

raghs-aws reopened this Aug 25, 2023

raghs-aws mentioned this pull request Aug 25, 2023

Support setting --reserved-cpus as kubelet argument #1334

Closed

nebm-aws approved these changes Aug 25, 2023

View reviewed changes

EC2 Default User added 2 commits August 29, 2023 02:44

rserved cpu option for containerd

6495e99

reserved cpu option for containerd

d0737fa

cartermckinnon requested changes Aug 29, 2023

View reviewed changes

files/bootstrap.sh Outdated Show resolved Hide resolved

files/bootstrap.sh Outdated Show resolved Hide resolved

test/cases/reserved-cpus-kubelet-arg.sh Outdated Show resolved Hide resolved

raghs-aws and others added 4 commits August 29, 2023 13:06

Update files/bootstrap.sh

9183de6

Co-authored-by: Carter <cartermckinnon@gmail.com>

Update test/cases/reserved-cpus-kubelet-arg.sh

9589d8b

Co-authored-by: Carter <cartermckinnon@gmail.com>

resolved review comments

189847a

Committer: raghs-aws

resolved review comments

3bcd64b

raghs-aws requested a review from cartermckinnon August 30, 2023 14:21

cartermckinnon reviewed Aug 30, 2023

View reviewed changes

raghs-aws added 2 commits August 30, 2023 11:02

updated bootstrap.sh

9eebfd8

updated bootstrap.sh

f934bb2

cartermckinnon approved these changes Aug 30, 2023

View reviewed changes

removed duplicate test case

26c0136

cartermckinnon merged commit 477759a into awslabs:master Aug 30, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't set default cgroup option if reserved-cpus provided via kubelet… #1405

don't set default cgroup option if reserved-cpus provided via kubelet… #1405

raghs-aws commented Aug 25, 2023

nebm-aws left a comment

nebm-aws left a comment

cartermckinnon commented Aug 26, 2023

github-actions bot commented Aug 26, 2023

github-actions bot commented Aug 26, 2023

raghs-aws commented Aug 28, 2023

cartermckinnon commented Aug 28, 2023

cartermckinnon left a comment

cartermckinnon Aug 30, 2023

raghs-aws Aug 30, 2023

cartermckinnon commented Aug 30, 2023 •

edited

Loading

raghs-aws commented Aug 30, 2023

raghs-aws commented Aug 30, 2023

don't set default cgroup option if reserved-cpus provided via kubelet… #1405

don't set default cgroup option if reserved-cpus provided via kubelet… #1405

Conversation

raghs-aws commented Aug 25, 2023

nebm-aws left a comment

Choose a reason for hiding this comment

nebm-aws left a comment

Choose a reason for hiding this comment

cartermckinnon commented Aug 26, 2023

github-actions bot commented Aug 26, 2023

github-actions bot commented Aug 26, 2023

raghs-aws commented Aug 28, 2023

cartermckinnon commented Aug 28, 2023

cartermckinnon left a comment

Choose a reason for hiding this comment

cartermckinnon Aug 30, 2023

Choose a reason for hiding this comment

raghs-aws Aug 30, 2023

Choose a reason for hiding this comment

cartermckinnon commented Aug 30, 2023 • edited Loading

raghs-aws commented Aug 30, 2023

raghs-aws commented Aug 30, 2023

cartermckinnon commented Aug 30, 2023 •

edited

Loading