Add shutdown requested implemention in python client. #53
Conversation
amazon_kclpy/kcl.py
Outdated
| :type checkpointer: amazon_kclpy.kcl.Checkpointer | ||
| :param checkpointer: A checkpointer which accepts a sequence number or no parameters. | ||
| ''' | ||
| raise NotImplementedError |
There was a problem hiding this comment.
This should probably do nothing. If someone upgrades to the newer version without implementing the shutdownRequested it would cause their application to fail.
There was a problem hiding this comment.
Additionally this should be placed on the v2 version of the record processor in v2/processor.py
amazon_kclpy/kcl.py
Outdated
| @@ -220,6 +220,17 @@ def shutdown(self, checkpointer, reason): | |||
| ''' | |||
| raise NotImplementedError | |||
|
|
|||
| @abc.abstractmethod | |||
| def shutdownRequested(self, checkpointer): | |||
There was a problem hiding this comment.
This should follow Python PEP8 style e.g. shutdown_requested.
For the v2 interface this should also use intermediate type, even though I did that wrong with the interface in the Java KCL. See v2/processor.py#L51 for an example
|
Thanks for the updates, one final thing: Please confirm that we can use, modify, copy, and redistribute this contribution. Thanks. |
|
@pfifer - Yes I approve that you can use, modify, copy and redistribute this contribution. Thanks, |
@pfifer - Starting this PR to add capability in python client to handle shutdown requested call. Added for java in PR awslabs/amazon-kinesis-client#174