Cancelling the LWS service from the handler #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… still return calls from the previous service call to the next one resulting in deallocated memory being accessed Checking whether to access the custom field and the object graph only when we need to handle the message Added unit test injecting timeout for connection Re-setting the state machine state on error to allow for further calls to connect from the client application.
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
Coverage ? 15.92%
=========================================
Files ? 33
Lines ? 7555
Branches ? 0
=========================================
Hits ? 1203
Misses ? 6352
Partials ? 0Continue to review full report at Codecov.
|
MushMal
force-pushed
the
connect_timeout
branch
from
1bef179
to
98bf0ed
Compare
Sean-Der
approved these changes
Jan 13, 2020
Closed
MushMal
force-pushed
the
connect_timeout
branch
from
a169790
to
12706d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancelling the LWS event loop from within the handler as the LWS will still return calls from the previous service call to the next one resulting in deallocated memory being accessed
Checking whether to access the custom field and the object graph only when we need to handle the message
Added unit test injecting timeout for connection
Re-setting the state machine state on error to allow for further calls to connect from the client application.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.