Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] add support to set a prefix for the S3 key #7 #120

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

evangilo
Copy link

IMPORTANT: I'm backporting the PR #118 to v1 branch.

*Issue #7 *

Description of changes:

This PR is adding an new attribute (s3KeyPrefix) for the ExtendedClientConfiguration class that will be used to compose the s3 key.

When the s3KeyPrefix is not null or empty, the S3 key object will use this attribute as prefix of the key. For example, if the s3KeyPrefix is queue-name/, the S3 key will be something like queue-name/676468c5-671f-4471-b9f6-fc5b0a5ab7de.

To keep the current behavior, the method payloadStore.storeOriginalPayload(messageContentStr, s3Key) will be used only if the s3KeyPrefix is not blank.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@evangilo evangilo changed the title add support to set a prefix for the S3 key #7 [BACKPORT] add support to set a prefix for the S3 key #7 Sep 28, 2023
@evangilo evangilo changed the title [BACKPORT] add support to set a prefix for the S3 key #7 [Backport] add support to set a prefix for the S3 key #7 Sep 28, 2023
@ziyanli-amazon ziyanli-amazon merged commit e351f8d into awslabs:v1 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants