Update JDK to 17. #177
Update JDK to 17. #177
Conversation
Switch from javax.jms.* to jakarta.jms.* namespace. Update testing libraries and maven plugins.
|
Can somebody from AWS / with write access please look at this. This would enable us to switch to spring boot 3 |
@AlexRosier at this moment no one will receive your message as there is no other participant, maybe you should mention someone from AWS java team. |
|
@ziyanli-amazon fyi ☝️ |
| @@ -179,26 +179,26 @@ public QueueSession createQueueSession(boolean transacted, int acknowledgeMode) | |||
| * transaction and acknowledge mode. | |||
| */ | |||
| @Override | |||
| public Session createSession(boolean transacted, int acknowledgeMode) throws JMSException { | |||
| public Session createSession(boolean transacted, int sessionMode) throws JMSException { | |||
There was a problem hiding this comment.
Any particular reason to change the variable naming here?
There was a problem hiding this comment.
ohhh, right, something went sideways from my side, just checked the signature of the method, I will revert it back tomorrow.
There was a problem hiding this comment.
@armogur thank you! I left some minor comments there, the majorities are format related. Please help us retain a good and uniformed package code style and convention. thanks a lot.
There was a problem hiding this comment.
fixed, please check.
|
|
||
| import com.amazon.sqs.javamessaging.message.SQSObjectMessage; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
| import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
Please do explicit import like
import static org.junit.jupiter.api.Assertions.assertNotNull
There was a problem hiding this comment.
Fixed in every file.
src/test/java/com/amazon/sqs/javamessaging/message/SQSObjectMessageTest.java
Show resolved
Hide resolved
| import static com.amazon.sqs.javamessaging.SQSMessagingClientConstants.APPROXIMATE_RECEIVE_COUNT; | ||
| import static com.amazon.sqs.javamessaging.SQSMessagingClientConstants.JMSX_DELIVERY_COUNT; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
| import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
Please do explicit import.
There was a problem hiding this comment.
Fixed in every file, please check.
src/test/java/com/amazon/sqs/javamessaging/message/SQSMessageTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/sqs/javamessaging/message/SQSBytesMessageTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/sqs/javamessaging/AmazonSQSMessagingClientWrapper.java
Outdated
Show resolved
Hide resolved
Rename variable in SQSConnection.
Replaced JUnit's assertEquals with assertJ's assertThat.
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-javadoc-plugin</artifactId> | ||
| <version>3.4.1</version> |
There was a problem hiding this comment.
I'm curious, did you see a lot of [WARNING] after upgrading the javadoc version here without having the <doclint>none</doclint> field?
There was a problem hiding this comment.
Thanks for doing this @armogur. I have also published a PR to java v1, awaiting for internal review.
Issue #, if available: 155
Description of changes:
Switch from javax.jms.* to jakarta.jms.* namespace.
Update testing libraries and maven plugins.
Update JDK to 17.
Code cleanup, fixed typos in comments, used newer assertions in test code.