Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track session states #729

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Track session states #729

merged 3 commits into from
Nov 17, 2023

Conversation

sergiyvamz
Copy link
Contributor

Summary

  • track session states
  • allow user to provide custom function to handle session state transfers

Description

Additional Reviewers

@karenc-bq
@davecramer
@hsuamz

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergiyvamz sergiyvamz changed the title [WIP] Track session states Track session states Nov 7, 2023
- allow user to provide custom function to handle session state transfers
@sergiyvamz sergiyvamz enabled auto-merge (squash) November 17, 2023 00:39
@sergiyvamz sergiyvamz merged commit 6ac6957 into main Nov 17, 2023
5 checks passed
@sergiyvamz sergiyvamz deleted the track-states branch November 17, 2023 01:00
@scott-long-adp
Copy link

thanks for this -- we will be using ConnectionProviderManager.setConnectionInitFunc() from #705 to initialize new connections that were not able to go through PoolBase.setupConnection()

Regarding SessionStateTransferCallable, RestoreSessionStateCallable -

The default behavior for SessionStateTransferCallable is to propagate all properties from one connection to the other, including transaction isolation -- so this new default behavior may actually be sufficient.

But the default behavior for RestoreSessionStateCallable is only to restore a locally-saved readonly and autocommit property.

What is the reason for the limited number of properties restored by RestoreSessionStateCallable compared to SessionStateTransferCallable? Should we consider a RestoreSessionStateCallable event similar to ConnectionProviderManager.setConnectionInitFunc() and just reset all properties from the ground up?

thanks for any insight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants