Fix a bunch of places we forget to aws_raise_error() (#229)

awslabs · Feb 13, 2024 · 0d2aa00 · 0d2aa00
1 parent 8e5e461
commit 0d2aa00
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -6,7 +6,7 @@ on:
       - 'main'
 
 env:
-  BUILDER_VERSION: v0.9.43
+  BUILDER_VERSION: v0.9.55
   BUILDER_SOURCE: releases
   BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
   PACKAGE_NAME: aws-c-auth

diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml
@@ -4,7 +4,7 @@ on:
   push:
 
 env:
-  BUILDER_VERSION: v0.9.29
+  BUILDER_VERSION: v0.9.55
   BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
   BUILDER_SOURCE: releases
   PACKAGE_NAME: aws-c-auth

diff --git a/source/aws_imds_client.c b/source/aws_imds_client.c
@@ -342,7 +342,7 @@ static int s_on_incoming_body_fn(struct aws_http_stream *stream, const struct aw
         AWS_LOGF_ERROR(
             AWS_LS_IMDS_CLIENT, "(id=%p) IMDS client query response exceeded maximum allowed length", (void *)client);
 
-        return AWS_OP_ERR;
+        return aws_raise_error(AWS_AUTH_IMDS_CLIENT_SOURCE_FAILURE);
     }
 
     if (aws_byte_buf_append_dynamic(&imds_user_data->current_result, data)) {

diff --git a/source/aws_signing.c b/source/aws_signing.c
@@ -2088,7 +2088,7 @@ int aws_signing_build_canonical_request(struct aws_signing_state_aws *state) {
             return s_apply_existing_canonical_request(state);
 
         default:
-            return AWS_OP_ERR;
+            return aws_raise_error(AWS_AUTH_SIGNING_UNSUPPORTED_SIGNATURE_TYPE);
     }
 }
 

diff --git a/source/signable_chunk.c b/source/signable_chunk.c
@@ -30,7 +30,7 @@ static int s_aws_signable_chunk_get_property(
     if (aws_string_eq(name, g_aws_previous_signature_property_name)) {
         *out_value = aws_byte_cursor_from_string(impl->previous_signature);
     } else {
-        return AWS_OP_ERR;
+        return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
     }
 
     return AWS_OP_SUCCESS;
@@ -44,7 +44,7 @@ static int s_aws_signable_chunk_get_property_list(
     (void)name;
     (void)out_list;
 
-    return AWS_OP_ERR;
+    return aws_raise_error(AWS_ERROR_UNSUPPORTED_OPERATION);
 }
 
 static int s_aws_signable_chunk_get_payload_stream(

diff --git a/source/signable_http_request.c b/source/signable_http_request.c
@@ -32,7 +32,7 @@ static int s_aws_signable_http_request_get_property(
     } else if (aws_string_eq(name, g_aws_http_method_property_name)) {
         aws_http_message_get_request_method(impl->request, out_value);
     } else {
-        return AWS_OP_ERR;
+        return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
     }
 
     return AWS_OP_SUCCESS;
@@ -50,7 +50,7 @@ static int s_aws_signable_http_request_get_property_list(
     if (aws_string_eq(name, g_aws_http_headers_property_list_name)) {
         *out_list = &impl->headers;
     } else {
-        return AWS_OP_ERR;
+        return aws_raise_error(AWS_ERROR_UNSUPPORTED_OPERATION);
     }
 
     return AWS_OP_SUCCESS;

diff --git a/source/signable_trailer.c b/source/signable_trailer.c
@@ -28,7 +28,7 @@ static int s_aws_signable_trailing_headers_get_property(
     if (aws_string_eq(name, g_aws_previous_signature_property_name)) {
         *out_value = aws_byte_cursor_from_string(impl->previous_signature);
     } else {
-        return AWS_OP_ERR;
+        return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
     }
     return AWS_OP_SUCCESS;
 }
@@ -48,7 +48,7 @@ static int s_aws_signable_trailing_headers_get_property_list(
     if (aws_string_eq(name, g_aws_http_headers_property_list_name)) {
         *out_list = &impl->headers;
     } else {
-        return AWS_OP_ERR;
+        return aws_raise_error(AWS_ERROR_UNSUPPORTED_OPERATION);
     }
 
     return AWS_OP_SUCCESS;

diff --git a/source/sigv4_http_request.c b/source/sigv4_http_request.c
@@ -154,7 +154,7 @@ int aws_apply_signing_result_to_http_request(
         }
 
         if (source_header.name == NULL || source_header.value == NULL) {
-            return AWS_OP_ERR;
+            return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
         }
 
         struct aws_http_header dest_header = {

diff --git a/tests/test_signable.c b/tests/test_signable.c
@@ -29,7 +29,7 @@ static int s_aws_signable_test_get_property(
     } else if (aws_string_eq(name, g_aws_http_method_property_name)) {
         *out_value = impl->method;
     } else {
-        return AWS_OP_ERR;
+        return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
     }
 
     return AWS_OP_SUCCESS;
@@ -47,7 +47,7 @@ static int s_aws_signable_test_get_property_list(
     if (aws_string_eq(name, g_aws_http_headers_property_list_name)) {
         *out_list = &impl->headers;
     } else {
-        return AWS_OP_ERR;
+        return aws_raise_error(AWS_ERROR_UNSUPPORTED_OPERATION);
     }
 
     return AWS_OP_SUCCESS;