Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of places we forget to aws_raise_error() #229

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix a bunch of places we forget to aws_raise_error() #229

merged 2 commits into from
Feb 13, 2024

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Feb 10, 2024

See: awslabs/aws-c-common#1089

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8e5e461) 79.67% compared to head (a3d7b54) 79.57%.

Files Patch % Lines
source/signable_chunk.c 0.00% 2 Missing ⚠️
source/signable_http_request.c 0.00% 2 Missing ⚠️
source/signable_trailer.c 0.00% 2 Missing ⚠️
source/aws_imds_client.c 0.00% 1 Missing ⚠️
source/aws_signing.c 0.00% 1 Missing ⚠️
source/sigv4_http_request.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   79.67%   79.57%   -0.10%     
==========================================
  Files          33       33              
  Lines        5834     5841       +7     
==========================================
  Hits         4648     4648              
- Misses       1186     1193       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graebm graebm merged commit 0d2aa00 into main Feb 13, 2024
28 of 29 checks passed
@graebm graebm deleted the bad-err branch February 13, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants