Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiration override #166

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Expiration override #166

merged 3 commits into from
Jun 14, 2022

Conversation

bretambrose
Copy link
Contributor

If present, credentials expiration time should override the blind refresh interval on the caching provider.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

grrtrr and others added 3 commits March 8, 2022 08:57
The cached credentials provider will only adjust its refresh interval when caching STS
web identity credentials (expiration_timepoint_seconds < UINT_MAX).

STS credentials are typically valid for 1h. The default refresh interval for the default
chain provider is 15 minutes.

Currently the cached credentials provider will only adjust its refresh interval if the
STS credentials expire within its refresh interval (via if-condition).

Consequently, the cached provider will refresh STS credentials 4 times more frequently than
required, increasing the load on the STS endpoint. This causes issues for large parallel
workloads, such as throttling STS requests.

Hence honor the longer expiration interval where possible.
@bretambrose bretambrose merged commit c44ae1e into main Jun 14, 2022
@bretambrose bretambrose deleted the ExpirationOverride branch June 14, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants