-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix STS Credentials Provider to use regional endpoint if possible #237
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 79.91% 80.22% +0.30%
==========================================
Files 33 33
Lines 5921 5958 +37
==========================================
+ Hits 4732 4780 +48
+ Misses 1189 1178 -11 ☔ View full report in Codecov by Sentry. |
source/credentials_utils.c
Outdated
|
||
int aws_credentials_provider_construct_regional_endpoint( | ||
struct aws_allocator *allocator, | ||
struct aws_byte_buf *out_endpoint, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debatable: is it better to hide the buf as impl detail and return string instead? dont have to deal with cleaning buf, worrying if they pass an existing buf, etc...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated. That's much better.
Issue #, if available:
awslabs/mountpoint-s3#861
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.