Fix STSCredentialsProvider Signing Region #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| aws_date_time_init_now(&provider_user_data->signing_config.date); | ||
| provider_user_data->signing_config.region = s_signing_region; | ||
| uint64_t now = UINT64_MAX; | ||
| if (impl->system_clock_fn(&now) != AWS_OP_SUCCESS) { |
There was a problem hiding this comment.
is this expected change?
There was a problem hiding this comment.
Are you asking about using the mocked system clock? We can avoid making this change and just assert on the prefix of the signature in tests; however, since we already had the option, it seemed more sensible to just use the mocked clock if set to keep it consistent. It also allows us to assert on the signature in tests.
There was a problem hiding this comment.
no was just checking whether you were intending to make this change or its something that slipped in accidentally. cause it looked somewhat unrelated to your changes. i see its for mocking now
DmitriyMusatkin
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.