Use fake pub key #163
Merged
Use fake pub key #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
approved these changes
Oct 11, 2023
| break; | ||
|
|
||
| default: | ||
| break; |
There was a problem hiding this comment.
we can fatal assert here? curve being supported should already have been verified
There was a problem hiding this comment.
I thought about that, but seems like our API doesn't really raise error for the unknown enum eg: https://github.com/awslabs/aws-c-cal/blob/main/source/windows/bcrypt_ecc.c#L56. But, yeah, I can raise the error here.
DmitriyMusatkin
approved these changes
Oct 11, 2023
| break; | ||
|
|
||
| default: | ||
| break; |
There was a problem hiding this comment.
we can fatal assert here? curve being supported should already have been verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use SecCreateKeyWithData to create ECC key. Expected format for the key passed to that api is a byte buffer consisting of "0x04 | x | y | p", where x,y is public pair and p is private key.
Note that in some cases we only have private key (as we derived it as described above) and we need to construct SecKey from that.
In those cases our code just passes 0,0 point for x,y, i.e. "0x04 | 0 | 0 | p".
This used to work on Macs before 14, but in 14+ SecCreateKeyWithData returns error, which is reasonable since 0,0 is not a valid public point.
To get around the issue, we use a fake public key, which is a valid public point, but not matching the private key as a quick workaround.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.