Dns #219
Closed
Dns #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * aws_dns_service_provider_config - Controls what host/port/protocol combos the default aws_dns_resolver uses to | ||
| * resolve queries. | ||
| * | ||
| * aws_host_resolution_service - A heavy-weight host name resolution service that contains CRT-specific and |
There was a problem hiding this comment.
why not just call this aws_dns_caching_resolver or something?
or aws_dns_cache
| * | ||
| * Shoulds: | ||
| * (1) Cache authority/zones-of-responsibility in a label-based tree (iterative only?) | ||
| * (2) Assume query input is a host name and not an IP address. |
There was a problem hiding this comment.
would this break existing systems that rely on querying an ip address just returning that ip address?
| enum aws_dns_resource_record_type type; | ||
|
|
||
| /* time-to-live in seconds */ | ||
| uint32_t ttl; |
There was a problem hiding this comment.
should we store time fetched or something so we can evaluate the TTL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of a proposed public interface for DNS and host resolution that includes full resolver implementations and separation of concerns between resolvers and CRT-desired functionality.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.