Windows cert chain now acts like rest of crt #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Dec 21, 2021
| @@ -603,7 +603,7 @@ int aws_import_key_pair_to_cert_context( | |||
| aws_raise_error(AWS_ERROR_SYS_CALL_FAILURE); | |||
| } | |||
|
|
|||
| if (i != cert_count - 1 || !add_result) { | |||
| if (i != 0 || !add_result) { | |||
There was a problem hiding this comment.
Let's build a new unit test that stresses using a certificate-chain
There was a problem hiding this comment.
we could probably just use a cert chain for the testing-resources unit test certs.
JonathanHenson
approved these changes
Jan 4, 2022
sbSteveK
force-pushed
the
cert_chain_win
branch
from
8e5dbc1
to
3bcdd20
Compare
This was referenced May 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed windows_pki_utils.c to process certificate chains in the same order as all other platforms.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.