Create setter for TLS Cipher Preference #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexw91
force-pushed
the
tls_cipher_pref_setter
branch
from
c8e159a
to
2259a7c
Compare
graebm
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Creates a
aws_tls_ctx_options_set_tls_cipher_preference()method that can be used by the C++ CRT SDK to match it's use of setter methods. Currently the Java CRT SDK is manually writing the enum into theaws_tls_ctx_optionsstruct instead of using a setter method.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.