Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup aws-lc thread locals in event loop threads #581

Merged
merged 7 commits into from
Jun 30, 2023
Merged

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Jun 27, 2023

Requires >= v1.11.0 of aws-lc

Part of the fix for awslabs/aws-crt-nodejs#452

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

source/linux/epoll_event_loop.c Outdated Show resolved Hide resolved
source/linux/epoll_event_loop.c Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (c3f95eb) 79.87% compared to head (4f22c75) 79.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   79.87%   79.88%   +0.01%     
==========================================
  Files          27       27              
  Lines        5838     5841       +3     
==========================================
+ Hits         4663     4666       +3     
  Misses       1175     1175              
Impacted Files Coverage Δ
source/linux/epoll_event_loop.c 87.20% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@graebm
Copy link
Contributor

graebm commented Jun 29, 2023

You need to update this line to get the ProofAlarm to pass

echo "8391c38acd85cca2a2892d02ebfd4ceb source/linux/epoll_event_loop.c" > $TMPFILE

@bretambrose bretambrose merged commit 1f9a085 into main Jun 30, 2023
33 checks passed
@bretambrose bretambrose deleted the ThreadLocal branch June 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants